[PATCH] net:: ECMP Phase 1 Fixes for FreeBSD 7.2
Balaji G
balajig81 at gmail.com
Wed Feb 10 17:26:36 UTC 2010
Hi Jhell
Thanks yeah i got it. Jassal told me this :) sorry i didnt look at it. Will
correct it when i generate the patches the next time as i am working on it
Thanks for your feedback. I hope i get in touch with some on the task list
soon :)
Cheers,
- Balaji
On Wed, Feb 10, 2010 at 10:38 PM, jhell <jhell at dataix.net> wrote:
>
> On Wed, 10 Feb 2010 01:53, balajig81@ wrote:
>
>> Hi Jhell
>>
>> Delete keys get in the way some times ;)
>>>
>>
>> I am sorry i didn't understand your comment. Is it wrong or should i
>> change
>> something, please let me know so that i could create an other patch .
>>
>>
> Please see below.
>
>
> PS: I had also sent an email to the list to take up some items mentioned
>> in
>> the Wiki Page under the networking section. It would be nice if by any
>> chance you know who's the contact person :). for those activities.
>>
>>
> I do not remember who the contact person is at the moment but it would be
> safe to say he/she is probably watching mailing list.
>
>
> Thanks for your feedback and time :)
>>
>> Thanks,
>> Cheers,
>> - Balaji
>>
>>
>> On Wed, Feb 10, 2010 at 12:11 PM, jhell <jhell at dataix.net> wrote:
>>
>>
>>> On Mon, 8 Feb 2010 10:39, balajig81@ wrote:
>>>
>>> Hi Everybody
>>>>
>>>> Please find attached the patch files which contains the backported code
>>>> for
>>>> ECMP for FreeBSD 7.2. I have back ported the code from 8.0. I have done
>>>> some
>>>> basic testing with these patches rolled in. These are the phase 1 fixes
>>>> and
>>>> i would continue to work on this and back port few other stuff too. It
>>>> would
>>>> be great if someone could roll in this to 7.2, test it and give me their
>>>> valuable feedback.
>>>>
>>>> This is my first Patch for FreeBSD community and i am really excited
>>>> about
>>>> this and look forward to it.
>>>>
>>>> Thanks for your time.
>>>>
>>>> Cheers,
>>>> - Balaji
>>>>
>>>>
>>>> In ecmp_patch1 you have,
>>>
>>> @@ -320,8 +320,9 @@
>>> #endif
>>>
>>> extern int in6_inithead(void **head, int off);
>>> -extern int in_inithead(void **head, int off);
>>> +extern int in_inthead(void **head, int off);
>>>
>>>
> Problem is with the above two lines explicitly "in_inthead" should be
> "in_inithead" but it looked to me like it was a mistake and that you did not
> mean to delete the "i" which is why I said the following.
>
>
> ??
>>>
>>> Delete keys get in the way some times ;)
>>>
>>> --
>>>
>>> jhell
>>>
>>>
>>>
>>
>
> Best regards.
>
> --
>
> jhell
>
>
More information about the freebsd-net
mailing list