bsnmp/snmpmod.h: #include <sys/queue.h> is missed

Eugene Grosbein egrosbein at rdtc.ru
Sat Dec 18 12:34:25 UTC 2010


On 18.12.2010 18:01, Shteryana Shopova wrote:

>>> bsnmp/snmpmod.h uses SLIST but does not includes <sys/queue.h>. This breaks
>>> net-mgmt/bsnmp-ucd port (ports/153153).
>>>
>>> Could somebody look at the attached patch?
>>
>> <sys/types.h>, as well as <sys/param.h> should be included before
>> other headers.
>>
> 
> And the explicit includes of those files should be removed from the
> sources of the bsnmpd(1) modules, I think. I will put this in SVN
> along with a couple of other patches I have for bsnmp in my queue.
> Sorry for not being able to reply sooner after this problem was
> reported. Also, the bsnmptools port should be marked as obsolete as
> the tools are now in head.

I don't think that a port should be marked obsoled due to changes in head.
People tend to use releases or STABLE. For now, ports tree support RELENG_7
and RELENG_8, so we should keep POLA until bsnmptool backported to branches
and releases with bsnmptool are out.

Eugene Grosbein


More information about the freebsd-net mailing list