[head tinderbox] failure on sparc64/sparc64
hrs at FreeBSD.org
Tue Jun 9 08:05:38 UTC 2009
"Bjoern A. Zeeb" <bzeeb-lists at lists.zabbadoz.net> wrote
in <20090609074144.O22887 at maildrop.int.zabbadoz.net>:
bz> On Tue, 9 Jun 2009, Xin LI wrote:
bz> > Danny Braniss wrote:
bz> >>> Xin, good day.
bz> >>> Mon, Jun 08, 2009 at 04:49:36PM -0700, Xin LI wrote:
bz> >>>> The attached patch should fix this, any objections?
bz> >>> Yes, you missed negation operator in the copyin check. The issue
bz> >>> was already fixed by hrs@ two hours ago:
bz> >>> http://svn.freebsd.org/viewvc/base?view=revision&revision=193796
bz> >> sorry to barge in, but:
bz> >> if ((options | GIF_FULLOPTS) == GIF_FULLOPTS)
bz> >> is not clear,
bz> >> if ((options & ~GIF_FULLOPTS) == 0)
bz> >> seems to be less offuscated or I'm missing something?
bz> > Yes this looks like the usually used idiom (perhaps more efficient
bz> > anyway)... I just kept the style consistent with the old code.
bz> > Hiroki-san, could you have a look at this and consider if we should
bz> > use
bz> > this idiom?
bz> Also see the mail I had sent in reply to the commit message yesterday.
Sorry, I overlooked some of the messages I received. Yes, the logic
was reversed and fixed now, but your patch including style fix looks
better to me. I will commit it. Thank you for your review!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 195 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-net/attachments/20090609/66e46eeb/attachment.pgp
More information about the freebsd-net