hw.bge.forced_collapse

[Igor Sysoev]

On Fri, Dec 04, 2009 at 11:51:40AM -0800, Pyun YongHyeon wrote:

> On Fri, Dec 04, 2009 at 10:11:14PM +0300, Igor Sysoev wrote:
> > On Fri, Dec 04, 2009 at 09:32:43AM -0800, Pyun YongHyeon wrote:
> > 
> > > On Fri, Dec 04, 2009 at 10:54:40AM +0300, Igor Sysoev wrote:
> > > > I saw commit introducing hw.bge.forced_collapse loader tunable.
> > > > Just intresting, why it can not be a sysctl ?
> > > 
> > > I didn't think the sysctl variable would be frequently changed
> > > in runtime except debugging driver so I took simple path.
> > 
> > I do not think it's worth to reboot server just to look how various
> > values affect on bandwidth and CPU usage, expecially in production.
> > 
> > As I understand the change is trivial:
> > 
> > -          CTLFLAG_RD
> > +          CTLFLAG_RW
> > 
> > since bge_forced_collapse is used atomically.
> > 
> 
> I have no problem changing it to RW but that case I may have to
> create actual sysctl node(e.g. dev.bge.0.forced_collapse) instead
> of hw.bge.forced_collapse which may affect all bge(4) controllers
> on system. Attached patch may be what you want. You can change the
> value at any time.

Thank you for the patch. Can it be installed on 8-STABLE ?


-- 
Igor Sysoev
http://sysoev.ru/en/