ifconfig patch

Andrew Thompson thompsa at FreeBSD.org
Thu Sep 20 17:03:38 PDT 2007


On Fri, Sep 21, 2007 at 11:54:27AM +1200, Andrew Thompson wrote:
> Hi,
> 
> 
> I have been digging into why the edsc module wasnt being loaded by
> ifconfig and now have a patch.
> 
> A few printfs showed the problem.
> 
> # ifconfig edsc0 create
> ifmaybeload(edsc0)
> trying to find if_edsc or edsc0
> found @ ed
> 
> Its comparing using the string length of the module name so any partial
> matches are going through. I have changed it so it strips the number
> from the interface name and uses the full string to match.
> 
> I want to ask re@ soon so any feedback would be great.
> 
> 
> Andrew

>  	*dp = 0;
>  
> +	/* trim the interface number off the end */
> +	strcpy(ifname, name);

oops, that should have been

        strlcpy(ifname, name, sizeof(ifname));

> +	for (dp = ifname; *dp != 0; dp++)
> +		if (isdigit(*dp))
> +			*dp = '\0';
> +


Andrew


More information about the freebsd-net mailing list