re0 - D-Link DGE-528T not recognised

[gareth]

hey guys, sorry about the break in thread, i've just joined
the mailing list and am copy/pasting from pipermail on the web.

i have the same problem as MaXX in his mail dated 'Sun May 6 11:53:56 UTC 2007'
(http://lists.freebsd.org/pipermail/freebsd-net/2007-May/014117.html).

Denis replied with a patch on 'Sat May 19 10:08:02 UTC 2007'
(http://lists.freebsd.org/pipermail/freebsd-net/2007-May/014195.html)
which read as:

--- /usr/src/sys/dev/re/if_re.c Wed Jan 24 03:57:50 2007
+++ /usr/src/sys/dev/re/if_re.c.new     Sat May 19 04:08:32 2007
@@ -168,6 +168,8 @@
  static struct rl_type re_devs[] = {
         { DLINK_VENDORID, DLINK_DEVICEID_528T, RL_HWREV_8169S,
                 "D-Link DGE-528(T) Gigabit Ethernet Adapter" },
+       { DLINK_VENDORID, DLINK_DEVICEID_528T, RL_HWREV_8169_8110SB,
+               "D-Link DGE-528(T) Rev.B1 Gigabit Ethernet Adapter" },
         { RT_VENDORID, RT_DEVICEID_8139, RL_HWREV_8139CPLUS,
                 "RealTek 8139C+ 10/100BaseTX" },
         { RT_VENDORID, RT_DEVICEID_8101E, RL_HWREV_8101E,


i did this but on compiling the kernel it stopped with error in if_re.c,
line 168: 'RL_HWREV_8169_8110SB' undeclared here (not in a function).

i found the corresponding declaration in /usr/src/sys/pci/if_rlreg.h
and did:


        #define RL_HWREV_8169SB		0x10000000
+       #define RL_HWREV_8169_8110SB	0x10000000


and looking around in the /usr/src/sys/pci/if_rl.c file i did this
just in case:

-                            hwrev == RL_HWREV_8110S) {
+                            hwrev == RL_HWREV_8110S ||
+                            hwrev == RL_HWREV_8169_8110SB) {


the kernel then recompiles without error and the network card
comes up and i can join a network. i have no idea what i was doing
though, and would like to know if i've done the right thing,
eg. setting the #define to 0x10000000 and not 0x04000000 etc.?


ps. i notice nothing else has been said on
http://www.freebsd.org/cgi/query-pr.cgi?pr=112774