kern/109815: wrong interface identifier at pfil_hooks for vlans + if_bridge

Eygene Ryabinkin rea-fbsd at codelabs.ru
Fri Mar 9 07:22:32 UTC 2007


> > 
> > +        /* Give a chance for ifp at first priority. This will help in case 
> > we
> > +         * the packet comes through the interface with VLAN's and the same
> > +         * MACs on several interfaces in a bridge. Also will save some 
> > circles
> > +         * in case dst interface is the physical input interface (eq ifp).
> > +         */
> > +        if (ifp->if_type == IFT_GIF
>                ^^^^^^^^^^^^^^^^^^^^^^^
> 	       is this check right?

No, it should read
if (ifp->if_type == IFT_GIF)
	continue;
if (memcmp(IF_LLADDR(.....))) {
	...
}
-- 
Eygene


More information about the freebsd-net mailing list