autobridge patch

Brooks Davis brooks at one-eyed-alien.net
Tue Jan 17 09:50:11 PST 2006


On Tue, Jan 17, 2006 at 09:32:03AM +0100, Marcin Jessa wrote:
> On Mon, 16 Jan 2006 10:03:33 -0800
> Brooks Davis <brooks at one-eyed-alien.net> wrote:
> 
> > On Mon, Jan 16, 2006 at 11:25:04AM +0000, Marcin Jessa wrote:
> > > On Mon, 16 Jan 2006 22:16:05 +1300
> > > Andrew Thompson <thompsa at freebsd.org> wrote:
> > > 
> > > > Hi,
> > > > 
> > > > 
> > > > I have a patch here that adds the ability to automatically add an
> > > > interface to a bridge when its attached. This is aimed towards
> > > > apps like qemu or vmware that open a tap interface and need it
> > > > bridged with the network adapter, the user can set up a glob for
> > > > interfaces to be automatically added (eg tap*). It may also be
> > > > useful for Xen dom0 support.
> > > > 
> > > > This patch includes a big change to how interfaces are configured
> > > > in userland. Before only physical Ethernet cards were handled by
> > > > devd, now _ALL_ interfaces are (vlans, pflog, pfsync, tap, tun,
> > > > etc..). This has the added bonus that the pseudo interfaces can
> > > > be configured after boottime in rc.conf, ifconfig_xxx="".
> > > > 
> > > > Please test this patch, even if you dont use a bridge. Im not in
> > > > a hurry to commit it.
> > > 
> > > I just rebuild and installed my world and kernel to test the
> > > patches. Seems like things did not work as expected.
> > > The name part of ifconfig_vlan0 left me with renamed but not
> > > configured device. The IP etc of VLAN01 was not set at boot. Am I
> > > doning something wrong?
> > > 
> > > cloned_interfaces="bridge0 vlan0"
> > > ifconfig_sk0="up"
> > > ifconfig_vlan0="name VLAN01 inet 10.137.99.4 vlan 1 vlandev sk0"
> > 
> > If you want to rename the vlan interface use:
> > 
> > ifconfig_vlan0_name="name VLAN01"
> > ifconfig_VLAN01="inet 10.137.99.4 vlan 1 vlandev sk0"
> 
> Actually only this will work:
> ifconfig_vlan0_name="VLAN01"
> ifconfig_VLAN01="inet 10.137.99.4 vlan 1 vlandev sk0"
> 
> One thing I noticed was VLAN01 could not be called something more
> descriptive like VLAN-FOO since then the startup scripts went bananas
> leaving my console in an ifconfig loop.

I know about that problem and plan to fix it (by collapsing the
namespace so that all unsupported characters are treated as though they
are _'s in the rc.conf scripts).  It's not super high on my current
list though so if someone else wasn't to do it, that would be great.

> There was a patch from bart <bart at convex.ru> that he posted to
> net@ adding possibility to add an ASCII description to devices the same
> way Cisco does. 
> Was it ever conserned as a commit candidate?

I plan to commit a revised version at some point, but first I want to
commit the ioctl changes I proposed a few days ago so we don't end up
with an implicit size encoded in the ioctl interface.

-- Brooks

-- 
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-net/attachments/20060117/2bff3120/attachment.bin


More information about the freebsd-net mailing list