Race condition in ip6_getpmtu (actually gif)?

Craig Boston craig at olyun.gank.org
Mon Feb 27 12:03:09 PST 2006


On Mon, Feb 20, 2006 at 08:15:57PM +0900, JINMEI Tatuya wrote:
> > Attached is a quick hack to protect the cached route with a mutex.  A
> > better fix with less overhead would be to allocate the route in a local
> > variable on the stack, and only copy it to the softc if route caching is
> > enabled.  I'll run for a couple weeks with the patch and file a PR if
> > that fixes it.
> 
> I guess this problem was fixed with the following changes:
> 
> http://www.jp.freebsd.org/cgi/cvsweb.cgi/src/sys/net/if_gif.c.diff?r1=1.57&r2=1.58
> http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/netinet6/in6_gif.c.diff?r1=1.23&r2=1.24

Yes, it was.  I saw the changes in those files when I attempted to
re-merge my patch after a cvsup.  I've currently been running with no
panics for 12 days with rev 1.52.2.4 of if_gif.c and rev 1.22.2.2 of
in6_gif.c.

Craig


More information about the freebsd-net mailing list