[was] addition to ipfw (read vlans from bridge)..

[Julian Elischer]

Yar Tikhiy wrote:

> 
> However, I have one question regarding "etype", please see below.
> 
[...]

>>  
>> +	/*
>> +	 * if we have an ether header,
>> +	 */
>> +	if (args->eh)
>> +		etype = (ntohs(args->eh->ether_type)) == ETHERTYPE_VLAN;
> 
> And here we assign a boolean value to etype.  Is it intended?
> Looks like a error to me.  Apparently it should read:
> 
> 		etype = ntohs(args->eh->ether_type);

exactly.. cut-n-paste-o

> 
> But some processing of the (etype == ETHERTYPE_VLAN) case may be
> missing here.

ipfw should not really be interested in the VLAN case with these changes.