if_nge & if_lge drivers
Yuriy N. Shkandybin
jura at networks.ru
Wed Oct 12 14:17:10 PDT 2005
>
> Note that lge() has a bzero() call after the contigmalloc(), but M_ZERO is
> probably better to use:
>
> sc->lge_ldata = contigmalloc(sizeof(struct lge_list_data), M_DEVBUF,
> M_NOWAIT, 0, 0xffffffff, PAGE_SIZE, 0);
>
> ...
> bzero(sc->lge_ldata, sizeof(struct lge_list_data));
>
Yes, i;ve missed that.
But there is no such bzero in nge.
> I'll put that in my lge(4) patches and incorporate your nge(4) patches.
> One
> issue with your nge(4) patch is that you moved the bus_setup_intr() up
> when
> it really should happen after ether_ifattach().
>
Probably.
I've looked into if_lge.c for that as example.
There goes bus_setup_intr() first and later ether_ifattach().
>
> Also, is there a reason you added a call to nge_reset() after nge_stop()
> in
> nge_init()?
>
Only reason - same done in if_lge.c
Jura
More information about the freebsd-net
mailing list