TCP MD5 Signature option handling in tcp_syncache.c

Noritoshi Demizu demizu at dd.iij4u.or.jp
Mon Jul 4 10:16:18 GMT 2005


>   1. When the TCP MD5 Signature option is used on a TCP connection,
>      both the TCP Timestamps option and the TCP Window Scale option
>      are turned off.
>
>      I think the cause and the fix are as following:
>      At line 987 in tcp_syncache.c 1.70, sc->sc_flags is overwritten
>      by SCF_SIGNATURE.  By this line, SCF_TIMESTAMP and SCF_WINSCALE
>      are turned off.  I think the operator "=" should be "|=".
>
>  987: -		sc->sc_flags = SCF_SIGNATURE;
>  987: +		sc->sc_flags |= SCF_SIGNATURE;

I files this problem as kern/82963.

Regards,
Noritoshi Demizu


More information about the freebsd-net mailing list