shutdown node VS disconnect all hooks

Julian Elischer julian at elischer.org
Fri May 28 08:16:06 GMT 2004



On Fri, 28 May 2004, Harti Brandt wrote:

> 
> [Sorry, I just deleted the original mail, so I use Julian's to answer]
> 
> On Thu, 27 May 2004, Julian Elischer wrote:
> 
> JE>On Fri, 28 May 2004, Gleb Smirnoff wrote:
> JE>
> JE>>   So, what about adding one more netgraph method into struct ng_type, say
> JE>> ng_preshutdown_t? This method is called first in ng_rmnode(), and then 
> JE>> current shutdown sequence is followed. We will set it to NULL in all existing
> JE>> nodes, and create a method in ng_tee, which calls ng_bypass(). Future
> JE>> implementations may use this method to send "goodbye" messages down hooks when
> JE>> shutting down.
> JE>
> JE>That sounds like a much better solution. Node shutdown is done in 2
> JE>parts just as node connection is done in 2 parts.
> JE>
> JE>>   And this will be a POLA-friendly solution - we will not lose functionality
> JE>> of RELENG_4 (which mpd relies on), and we will not break nodes which
> JE>> rely on current shutdown sequence.
> JE>> 
> JE>>   What's your opinion? If it is positive - I'll send patches.
> JE>> 
> JE>
> JE>That is a very workable solution.
> 
> If you do that, I suppose you need to edit all the nodes, right?. In that
> case could you please convert the initialisation of the typestructs
> to use C99 sparse initialisation? In that case future changes will be a good
> deal easier.

actually I don't know if you do need to edit the nodes
types.. At one time it was true that unassigned elements on
the end will be NULL.


> 
> harti
> 



More information about the freebsd-net mailing list