New preview patch for ipfw to pfil_hooks conversion
andre at freebsd.org
Tue Jun 22 11:38:56 GMT 2004
Maxim Konovalov wrote:
> Hi Andre,
> On Mon, 21 Jun 2004, 23:36+0200, Andre Oppermann wrote:
> > Here is the next preview patch for the ipfw to pfil_hooks conversion:
> > http://www.nrg4u.com/freebsd/ipfw-pfilhooks-and-more-20040621.diff
> > This patch significantly cleans up ip_input.c and ip_output.c.
> Is it possible to split that ~100KB patch in a logic chunks? One for
> phil_hook, one for ip_pcbopt, one for ip_reass etc. Much easier to
> review and commit them later.
Of course it will be split up. I haven't done this because this is
only a preview patch of work in progress.
> > Consider this a FYI. It is very much a WIP at the moment. I want
> > to get this into the tree in before 5.3 code freeze.
> In fact, our real world tests shown the current -CURRENT comparing to
> RELENG_5_2 is in a very bad shape. Is it really worth to commit that
> mostly cleanup code before say 6-CURRENT with a chance to
> destabilizate -CURRENT a bit more?
This will not destabilize -CURRENT anymore. Any errors in the code
are seen immediatly.
More information about the freebsd-net