Another bug with netmasked aliases (with fix)

Ruslan Ermilov ru at freebsd.org
Wed Dec 8 13:11:25 PST 2004


Hi Max,

On Wed, Dec 08, 2004 at 09:06:58PM +0100, Max Laier wrote:
> Any reason you didn't include the following (also part
> of OpenBSD rev. 1.47)?:
> 
I developed it independently of OpenBSD, and only later
found that OpenBSD also had it, so I missed this part.
It's indeed needed.

> |       /*
> |        * make sure to set rt->rt_ifa to the interface
> |        * address we are using, otherwise we will have trouble
> |        * with source address selection.
> |        */
> |       ifa = &ia->ia_ifa;
> |       if (ifa != rt->rt_ifa) {
> |               IFAFREE(rt->rt_ifa);
> |               ifa->ifa_refcnt++;
> |               rt->rt_ifa = ifa;
> |       }
> 
> 
> Updated diff attached. Not sure if it makes any difference?
> 
Of course it does.  Without it, "ping <alias>" comes from
the main address, where it should come from <alias>.

Reviewed.  Please commit.


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-net/attachments/20041208/e2a9300c/attachment.bin


More information about the freebsd-net mailing list