kern/73129: [patch] IPFW misbehaviour in RELENG_5

[Gleb Smirnoff]

  Andre,

  what is reason for these two checks in ip_output():

                if (!in_localip(ip->ip_src) && !in_localaddr(ip->ip_dst)) {
                        dst = (struct sockaddr_in *)&ro->ro_dst;
                        bcopy((fwd_tag+1), dst, sizeof(struct sockaddr_in));
                        m->m_flags |= M_SKIP_FIREWALL;
                        m_tag_delete(m, fwd_tag);
                        goto again;
                } else {
                        m_tag_delete(m, fwd_tag);
                        /* Continue. */
                }

Investigating pre-PFIL_HOOKS ipfw I have not found any analog of this check.
These checks do break some useful functionality:

1) policy routing of hosts from connected networks
2) policy routing of locally originated traffic

The second one is used very widely. When you have lines to two ISPs and
run natd for both of them, you policy route nated packets to them.

P.S. kern/73129, kern/73910, kern/71910

-- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE