netgraph only on i386/ia64 - why ?
harti at freebsd.org
Wed Aug 18 11:31:21 PDT 2004
On Wed, 18 Aug 2004, John Polstra wrote:
JP>On 18-Aug-2004 Julian Elischer wrote:
JP>> John Polstra wrote:
JP>>> There is one problem with netgraph on 64-bit platforms. The ng_msghdr
JP>>> struct is 52 bytes / 4-byte aligned (see ng_message.h). That means
JP>>> the message payload is not well-aligned for 64-bit platforms. It
JP>>> would be nice to fix that (and bump NG_VERSION, of course). Nobody
JP>>> ever guaranteed that the message payload would be aligned, but it
JP>>> makes things a lot more convenient.
JP>> if we do this we should do it now so that we have a consistent ABI from 5.3 on..
JP>> scott (et al), should we pad an extra 4 bytes in this now?
JP>> it's low/no risk, but better now than after 5.3 has been released..
JP>I'd really like to see this change happen. Julian, would it require
Yes. Please do it.
JP>bumping just NG_VERSION, or should NG_ABI_VERSION change too?
More information about the freebsd-net