Fwd: 5.2-RC + ipfw

[Maxim Konovalov]

On Sun, 14 Dec 2003, 12:23-0000, Nate Grey wrote:

> On Saturday 13 December 2003 18:47, Maxim Konovalov wrote:
> > Please try an enclosed patch or put a whitespace right after the '('
> > before '\'.
> >
> > Index: ipfw2.c
> > ===================================================================
> > RCS file: /home/ncvs/src/sbin/ipfw/ipfw2.c,v
> > retrieving revision 1.42
> > diff -u -r1.42 ipfw2.c
> > --- ipfw2.c	31 Oct 2003 18:31:55 -0000	1.42
> > +++ ipfw2.c	13 Dec 2003 18:42:18 -0000
> > @@ -2901,15 +2901,14 @@
> >  		goto done;
> >
> >  #define OR_START(target)					\
> > -	if (ac && (*av[0] == '(' || *av[0] == '{')) {		\
> > +	if (ac && (						\
> > +	    !strncmp(*av, "(", strlen(*av)) ||			\
> > +	    !strncmp(*av, "{", strlen(*av)) )) {		\
> >  		if (open_par)					\
> >  			errx(EX_USAGE, "nested \"(\" not allowed\n"); \
> >  		prev = NULL;					\
> >  		open_par = 1;					\
> > -		if ( (av[0])[1] == '\0') {			\
> > -			ac--; av++;				\
> > -		} else						\
> > -			(*av)++;				\
> > +		ac--; av++;					\
> >  	}							\
> >  	target:							\
> >
> > %%%
>
> Problem solved just adding a whitespace. Should I apply the patch anyway?

Please do if you can.  Thanks.

-- 
Maxim Konovalov, maxim at macomnet.ru, maxim at FreeBSD.org