maintainer-approval requested: [Bug 229339] audio/faad: Fix build on powerpc (and maybe powerpc64?) : [Attachment 194643] faad.diff

[bugzilla-noreply at freebsd.org]

Tobias Kortkamp <tobik at freebsd.org> has asked freebsd-multimedia mailing list
<multimedia at FreeBSD.org> for maintainer-approval:
Bug 229339: audio/faad: Fix build on powerpc (and maybe powerpc64?)
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229339

Attachment 194643: faad.diff
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=194643&action=edit



--- Description ---
Building faad on powerpc fails with

Making all in frontend
gmake[3]: Entering directory
'/construction/usr/ports/audio/faad/work/faad2-2.8.8/frontend'
/bin/sh ../libtool  --tag=CC   --mode=link cc  -O2 -pipe  -fno-strict-aliasing 
-lpthread -L/usr/local/lib -o faad mp4read.o audio.o main.o unicode_support.o
../libfaad/libfaad.la 
libtool: link: cc -O2 -pipe -fno-strict-aliasing -o .libs/faad mp4read.o
audio.o main.o unicode_support.o  -L/usr/local/lib ../libfaad/.libs/libfaad.so
-lpthread -lm -Wl,-rpath -Wl,/usr/local/lib
mp4read.o: In function `u16in':
mp4read.c:(.text+0x674): undefined reference to `__builtin_bswap16'

frontend/mp4read.c doesn't include config.h so WORDS_BIGENDIAN is
not defined and bswap16() breaks.  I'm attaching a fix.

The error message on powerpc64 seems to be the same, so I'm cautiously
optimistic that this might fix the build on powerpc64 too.  But I
have no way to test.