Fixing skype multimedia/linux_v4l2wrapper dependency on 8

[Ion-Mihai Tetcu]

On Mon, 18 Jul 2011 22:37:34 +0200
Alexander Leidinger <Alexander at Leidinger.net> wrote:

> > > > +.else
> > > > +.if ${OSVERSION} == 900036 || ${OSVERSION} == 802508
> > > > +LINUX_V4L2_INBASE!=	($(SYSCTL) -n
> > > > kern.features.linuxulator_v4l2    
> > > > 2>/dev/null || true)  
> > > 
> > > Here you say it can only be used *if it is loaded or compiled in*.
> > >   
> >  Yeah it is a crude check which will fail if linux.ko isn't loaded
> > (or statically compiled in.)  I only added this because you didn't
> > bump __FreeBSD_version so these OSVERSIONs can either have it or
> > not.  But since it's the best I could come up in with this situation
> > and the only harm done would be the linux_v4l2wrapper.ko would get
> > installed when it is not needed I think it's justified.  (The kld
> > probably could even be loaded when the code is in the kernel already
> > and skype would still work...  Hmm or should we just depend on that
> > and on these OSVERSIONs install the kld unconditionally?)  
> 
> It depends on what you want to achieve. IMO just wait for complains
> that it does not work. If nobody complains, it may be that it is not
> necessary to invest the time and energy to change this. As there are
> more places which depend upon linux-stuff being in memory, I would
> assume that most people which want to install skype already have it in
> memory at the time when the check is run.

had about 4 people complain about .... all of which didn't had newer
enough OSVERSION or did not bother to setup alsa right ... not sure if
it's worth the trouble spending time on this ...


-- 
IOnut - Un^d^dregistered ;) FreeBSD "user"
  "Intellectual Property" is   nowhere near as valuable   as "Intellect"
FreeBSD committer -> itetcu at FreeBSD.org, PGP Key ID 057E9F8B493A297B
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-multimedia/attachments/20110718/5f703d35/signature.pgp