[PATCH] multimedia/x264: update to 0.0.20091124
Wes Morgan
morganw at chemikals.org
Sat Nov 28 06:22:04 UTC 2009
On Fri, 27 Nov 2009, Gea-Suan Lin wrote:
> Thanks for the url. I've used another approach that define
> log2f(x) = (log(x) / M_LN2) when log2f not defined, this way will be
> much simple.
>
> Please check http://colo-p.gslin.org/~gslin/tmp/x264.shar this version.
I'll give it a test run. I tried simply changing the log base before with
just the actualy value in the file (wasn't aware of M_LN2) and I got some
strange floating point errors in x264. May have been something else wrong,
though.
Also, if I build with gcc44 and enable assembly, I get 3-4x the encoding
speed. As a side effect, the stack protection must also be disabled. Just
a thought!
> On Wed, Nov 25, 2009 at 01:56:06PM -0600, Wes Morgan wrote:
>> On Thu, 26 Nov 2009, Gea-Suan Lin wrote:
>>
>>>
>>>> Submitter-Id: current-users
>>>> Originator: Gea-Suan Lin
>>>> Organization:
>>>> Confidential: no
>>>> Synopsis: [PATCH] multimedia/x264: update to 0.0.20091124
>>>> Severity: non-critical
>>>> Priority: low
>>>> Category: ports
>>>> Class: update
>>>> Release: FreeBSD 7.2-RELEASE-p3 i386
>>>> Environment:
>>> System: FreeBSD colo-p.gslin.org 7.2-RELEASE-p3 FreeBSD 7.2-RELEASE-p3 #0: Sat Aug 22 10:48:39 CST 2009
>>>> Description:
>>> - Update to 0.0.20091124
>>>
>>> Port maintainer (multimedia at FreeBSD.org) is cc'd.
>>>
>>> Generated with FreeBSD Port Tools 0.99
>>>> How-To-Repeat:
>>>> Fix:
>>>
>>> --- x264-0.0.20091124.patch begins here ---
>>> diff -ruN --exclude=CVS /usr/ports/multimedia/x264/Makefile /home/staff/gslin/work/ports/x264/Makefile
>>> --- /usr/ports/multimedia/x264/Makefile 2009-11-23 04:28:29.000000000 +0800
>>> +++ /home/staff/gslin/work/ports/x264/Makefile 2009-11-26 00:13:16.000000000 +0800
>>> @@ -6,7 +6,7 @@
>>> # $Id: Makefile 30 2006-10-30 22:15:26Z buhnux $
>>>
>>> PORTNAME= x264
>>> -PORTVERSION= 0.0.20081218
>>> +PORTVERSION= 0.0.20091124
>>> CATEGORIES= multimedia
>>> MASTER_SITES= http://downloads.videolan.org/pub/videolan/x264/snapshots/ \
>>> http://samples.mplayerhq.hu/yuv4mpeg2/:pgo
>>> @@ -16,7 +16,7 @@
>>> EXTRACT_ONLY= ${PORTNAME}-snapshot-${PORTVERSION:S/0.0.//}-2245${EXTRACT_SUFX}
>>>
>>> MAINTAINER= multimedia at FreeBSD.org
>>> -COMMENT?= Multimedia library and tool for encoding H.264/AVC video streams
>>> +COMMENT= Multimedia library and tool for encoding H.264/AVC video streams
>>>
>>> BUILD_DEPENDS= yasm>=0.6.0:${PORTSDIR}/devel/yasm
>>>
>>> @@ -36,7 +36,7 @@
>>>
>>> CONFIGURE_ARGS+= --extra-cflags="${CPPFLAGS} ${CFLAGS} -fPIC -I${LOCALBASE}/include -I${LOCALBASE}/include" \
>>> --extra-ldflags="${LDFLAGS} -L${LOCALBASE}/lib -L${LOCALBASE}/lib" \
>>> - --enable-shared
>>> + --enable-shared --disable-asm
>>
>> I'm pretty certain that this will not work on amd64. The gcc internal
>> "log2f" function won't be picked up. See this email for a fix:
>>
>> http://lists.freebsd.org/pipermail/freebsd-multimedia/2009-March/009819.html
>>
>> Would it also be possible to add knobs for enabling the internal assembler
>> and adding dependencies on both binutils and gcc 4.4 from ports? I've been
>> using a snapshot built this way for about 2 weeks now doing some pretty
>> heavy encoding and have no problems other than the log2f patch.
>
>
More information about the freebsd-multimedia
mailing list