[PATCH] MPEG2-TS patch for fwcontrol

[John-Mark Gurney]

Petr Holub wrote this message on Tue, Nov 08, 2005 at 09:10 +0100:
> I've created a patchset for capturing MPEG2-TS and HDV from FireWire
> link using fwcontrol. It supports auto-detection of DV and MPEG2-TS
> when using -R flag. Patches are available for 5.x (reported to
> work under 4.x as well) and 6.x (I don't know if that's gonna work
> under -CURRENT). Basic idea for this patch was to be able to read
> HDV video from cameras like SONY HVR-Z1E or HDR-FX1, which are now
> becomming pretty affordable.
> 
> for 5.x: http://sitola.fi.muni.cz/~hopet/HDV/fwcontrol.patch
> for 6.x: http://sitola.fi.muni.cz/~hopet/HDV/fwcontrol-6.0.patch
> 
> Do you think it would be possible to have that patch integrated
> into the base system? I've sent this patch approximately half a year
> ago, got some basic positive response but the list seems to be rather
> dead since then :(.

Looks good, though you have a number of lines, both in the man page
and in source that are over 80 columns...  also, a quick pass after
reading style(9) would be good...  (variables aren't sorted properly
in mpegtsrecv, else not on same line as brace, spaces around if missing)..
you might want to update the year of the copyright :)

Otherwise looks good... Have you looked at being able to send MPEG2-TS?
I wonder if it'd work w/ a DVHS deck, or a firewire capable HDTV tuner
like the Samsung SIR-T165...

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."