maestro3 hardware volume control

[Scott Long]

Pyun YongHyeon wrote:
> Hi,
> 
> I noticed hardware volume control of maestro3 didn't work.  With
> small patch it worked on my system(Gateway Solo 5300).
> 
> Hardware volume control of maestro3 can be configured with two
> different control pins. Unfortunately it seems that it's hard to
> know which control pin was wired to control the volume.
> At present maestro3 provides a way via hint file to select one of
> the two configurations.
> 
> hint.pcm.0.hwvol_config="0" : select GD(game port interface) pin 6, 7
> hint.pcm.0.hwvol_config="1" : select GPIO pin 4,5
> If there is no hint the driver select GD pin 6, 7.
> 
> In my system selecting GD pins didn't work and a comment at the
> beginning of the driver source indicates it didn't ever work. So I'd
> like to change to select GPIO pins as a default hardware volume
> control. For users needs to select GD pins it could be easily done
> with hint.pcm.0.hwvol_config="0" in /boot/device.hints file.
> But I think there are no such users since device.hints file had no
> such entry.
> 

I believe that the source comment was out of date.  It certainly worked
when I wrote the code (see rev 1.11).  However, you're doing a much 
better job of maintaining this driver than I, so you're welcome to
change it as you see fit.  Make sure that it gets documented, though.

Scott