Massive sound changes / fix (24/32bit pcm support, new sampling rate converter, various fixes)

[Ariff Abdullah]

On Sat, 9 Jul 2005 20:39:33 +0200
Alexander Leidinger <Alexander at Leidinger.net> wrote:
> On Thu, 7 Jul 2005 06:46:03 +0800
> Ariff Abdullah <skywizard at MyBSD.org.my> wrote:
> 
> 
> > 2. mixer.c / sound.c (high priority / grave severity)
> >    * Fix super grave serious (call it whatever) panic/death during
> >      driver unload on second attempt after failure on first
> >      (device busy).
> 
> Seems to work. Tested with kldunload an a busy mixer several times,
> no panic. After that I did a successful unload (without a panic) and
> reload.
>
Great!

> > Hardware spessific changes
> > ==========================
> 
> > 3. es137x.c / es137x.h
> >    * Register programming error during device initialization
> >      especially for CT4730 / EV1938 chip, causing misconfigured
> >      mixer (David Xu), crippled after power cycle (Kevin Oberman).
> >      Fixed.
> >    * Incorporate locking/spdif patches from Jon Noack. Not all
> >    es137x
> >      can really do spdif, clean it up a bit to only let few
> >      capable chip.
> 
> --- /var/log/dmesg.today        Sat Jul  9 13:13:45 2005
> +++ /var/run/dmesg.boot Sat Jul  9 20:04:47 2005
> @@ -57,7 +57,6 @@
>  pci0: <multimedia, audio> at device 7.5 (no driver attached)
>  pcm0: <Creative CT5880-C> port 0xb800-0xb83f irq 5 at device 9.0 on
>  pci0 pcm0: <SigmaTel STAC9721/23 AC97 Codec>
> -pcm0: [GIANT-LOCKED]
>  xl0: <3Com 3c905C-TX Fast Etherlink XL> port 0xbc00-0xbc7f mem
>  0xe7000000-0xe700007f irq 11 at device 10.0 on pci0 miibus0: <MII
>  bus> on xl0 xlphy0: <3c905C 10/100 internal PHY> on miibus0
> 
> And the music plays just fine, no bad behavior so far.
>
Credit goes to Jonathan Noack for adding spdif / locking. If you think
there are lots of pops / crackling sound, you may as well play around
with sysctl hw.snd.pcm0.latency_timer (especially during untarring big
tarball).

> > 5. via82c686.c
> >    * Add locking / MPSAFE. I don't have this card, so other people
> >    had
> >      to confirm it. Anyway, the logic is correct.
> 
> pcm1: <VIA VT82C686A> port 0xac00-0xacff,0xb000-0xb003,0xb400-0xb403
> irq 11 at device 7.5 on pci0 pcm1: <SigmaTel STAC9721/23 AC97 Codec>
> 
> I didn't got any sound out of it... but I have to say I don't use it
> since it sounds horrible (maybe some hardware defect), so I don't
> know if it still worked without your patch.
If it's not bothering you too much, can you revert back to the
original and confirm that the hardware really broken? (I'm afraid I've
touched so many places and things start to become grumpy elsewhere).
It's ok of you feel that is enough.

Thanks for your feedback!


--

Ariff Abdullah
MyBSD

http://www.MyBSD.org.my (IPv6/IPv4)
http://staff.MyBSD.org.my (IPv6/IPv4)
http://tomoyo.MyBSD.org.my (IPv6/IPv4)