gxemul_disk.c
Juli Mallett
jmallett at FreeBSD.org
Mon Sep 3 00:59:55 UTC 2012
Indeed, you seem to be quite right. Feel free to commit the fix.
Thanks,
Juli.
On Sun, Sep 2, 2012 at 4:07 PM, Alan Cox <alc at rice.edu> wrote:
> There appears to be a simple typo in gxemul_disk.c that prevents changes
> from being written back to the emulated disk:
>
> Index: dev/gxemul/disk/gxemul_disk.c
> ===================================================================
> --- dev/gxemul/disk/gxemul_disk.c (revision 240002)
> +++ dev/gxemul/disk/gxemul_disk.c (working copy)
> @@ -286,7 +286,7 @@ gxemul_disk_write(unsigned diskid, const void *buf
> dst = GXEMUL_DISK_DEV_FUNCTION(GXEMUL_DISK_DEV_BLOCK);
> memcpy((void *)(uintptr_t)dst, buf, GXEMUL_DISK_DEV_BLOCKSIZE);
>
> - GXEMUL_DISK_DEV_WRITE(GXEMUL_DISK_DEV_START,
> GXEMUL_DISK_DEV_START_READ);
> + GXEMUL_DISK_DEV_WRITE(GXEMUL_DISK_DEV_START,
> GXEMUL_DISK_DEV_START_WRITE);
> switch (GXEMUL_DISK_DEV_READ(GXEMUL_DISK_DEV_STATUS)) {
> case GXEMUL_DISK_DEV_STATUS_FAILURE:
> return (EIO);
>
> Or am I missing something?
>
> Regards,
> Alan
>
More information about the freebsd-mips
mailing list