[patch] enable mdio port 1, remove phy mask hard coding
Aleksandr Rybalko
ray at dlink.ua
Wed Mar 28 20:03:09 UTC 2012
On Wed, 28 Mar 2012 11:24:35 -0700
Adrian Chadd <adrian at freebsd.org> wrote:
> Hi,
>
> The point is that we're talking to MDIO bus 0 or 1.
>
> Why is that not clear? :)
Because patched if_arge use it only with sc->arge_mac_unit, which is 0
for arge0, and 1 for arge1.
So there is two ways:
1. Just remove unit argument.
"ARGE_MII_READ(AR71XX_MAC_MII_INDICATOR)" instead of
"ARGE_MII_READ(sc->arge_mac_unit,AR71XX_MAC_MII_INDICATOR)"
2. or remove it completely, since for that case
ARGE_READ/ARGE_WRITE will do the same.
But if you will use here another variable, (f.e.
sc->arge_mdio_unit or sc->arge_mii_unit), then it would have sense.
Then you will be able to set it from hints and default to
sc->arge_mac_unit otherwise.
>
>
>
> Adrian
--
Aleksandr Rybalko <ray at dlink.ua>
More information about the freebsd-mips
mailing list