From tinderbox at freebsd.org Sun Nov 1 21:25:34 2009 From: tinderbox at freebsd.org (FreeBSD Tinderbox) Date: Sun Nov 1 21:25:46 2009 Subject: [releng_8 tinderbox] failure on mips/mips Message-ID: <200911012223.nA1MNGVX024269@freebsd-current.sentex.ca> TB --- 2009-11-01 22:13:08 - tinderbox 2.6 running on freebsd-current.sentex.ca TB --- 2009-11-01 22:13:08 - starting RELENG_8 tinderbox run for mips/mips TB --- 2009-11-01 22:13:08 - cleaning the object tree TB --- 2009-11-01 22:13:18 - cvsupping the source tree TB --- 2009-11-01 22:13:18 - /usr/bin/csup -z -r 3 -g -L 1 -h cvsup.sentex.ca /tinderbox/RELENG_8/mips/mips/supfile TB --- 2009-11-01 22:13:48 - building world TB --- 2009-11-01 22:13:48 - MAKEOBJDIRPREFIX=/obj TB --- 2009-11-01 22:13:48 - PATH=/usr/bin:/usr/sbin:/bin:/sbin TB --- 2009-11-01 22:13:48 - TARGET=mips TB --- 2009-11-01 22:13:48 - TARGET_ARCH=mips TB --- 2009-11-01 22:13:48 - TZ=UTC TB --- 2009-11-01 22:13:48 - __MAKE_CONF=/dev/null TB --- 2009-11-01 22:13:48 - cd /src TB --- 2009-11-01 22:13:48 - /usr/bin/make -B buildworld >>> World build started on Sun Nov 1 22:13:49 UTC 2009 >>> Rebuilding the temporary build tree >>> stage 1.1: legacy release compatibility shims >>> stage 1.2: bootstrap tools >>> stage 2.1: cleaning up the object tree >>> stage 2.2: rebuilding the object tree >>> stage 2.3: build tools >>> stage 3: cross tools >>> stage 4.1: building includes >>> stage 4.2: building libraries [...] cc -O -pipe -EL -msoft-float -G0 -mno-dsp -mabicalls -I/src/lib/libc/include -I/src/lib/libc/../../include -I/src/lib/libc/mips -DNLS -DSOFTFLOAT -D__DBINTERFACE_PRIVATE -I/src/lib/libc/../../contrib/gdtoa -DINET6 -I/obj/mips/src/lib/libc -I/src/lib/libc/resolv -D_ACL_PRIVATE -DPOSIX_MISTAKE -I/src/lib/libc/locale -DBROKEN_DES -DPORTMAP -DDES_BUILTIN -I/src/lib/libc/rpc -DYP -DNS_CACHING -DSYMBOL_VERSIONING -std=gnu99 -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -Wno-pointer-sign -c /src/lib/libc/string/wmemmove.c cc -O -pipe -EL -msoft-float -G0 -mno-dsp -mabicalls -I/src/lib/libc/include -I/src/lib/libc/../../include -I/src/lib/libc/mips -DNLS -DSOFTFLOAT -D__DBINTERFACE_PRIVATE -I/src/lib/libc/../../contrib/gdtoa -DINET6 -I/obj/mips/src/lib/libc -I/src/lib/libc/resolv -D_ACL_PRIVATE -DPOSIX_MISTAKE -I/src/lib/libc/locale -DBROKEN_DES -DPORTMAP -DDES_BUILTIN -I/src/lib/libc/rpc -DYP -DNS_CACHING -DSYMBOL_VERSIONING -std=gnu99 -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -Wno-pointer-sign -c /src/lib/libc/string/wmemset.c building static c library ranlib libc.a cat /src/lib/libc/mips/Symbol.map /src/lib/libc/db/Symbol.map /src/lib/libc/compat-43/Symbol.map /src/lib/libc/gdtoa/Symbol.map /src/lib/libc/gen/Symbol.map /src/lib/libc/gmon/Symbol.map /src/lib/libc/inet/Symbol.map /src/lib/libc/locale/Symbol.map /src/lib/libc/nameser/Symbol.map /src/lib/libc/net/Symbol.map /src/lib/libc/nls/Symbol.map /src/lib/libc/posix1e/Symbol.map /src/lib/libc/quad/Symbol.map /src/lib/libc/regex/Symbol.map /src/lib/libc/resolv/Symbol.map /src/lib/libc/stdio/Symbol.map /src/lib/libc/stdlib/Symbol.map /src/lib/libc/stdtime/Symbol.map /src/lib/libc/string/Symbol.map /src/lib/libc/sys/Symbol.map /src/lib/libc/rpc/Symbol.map /src/lib/libc/uuid/Symbol.map /src/lib/libc/xdr/Symbol.map /src/lib/libc/yp/Symbol.map | cpp - - | awk -v vfile=/src/lib/libc/Versions.def -f /src/share/mk/version_gen.awk > Version.map File , line 507: Undefined library version `FBSD_1.2'. File , line 508: Symbol `getpagesizes' outside version scope. 2 error(s) total. *** Error code 1 Stop in /src/lib/libc. *** Error code 1 Stop in /src. *** Error code 1 Stop in /src. *** Error code 1 Stop in /src. *** Error code 1 Stop in /src. TB --- 2009-11-01 22:23:16 - WARNING: /usr/bin/make returned exit code 1 TB --- 2009-11-01 22:23:16 - ERROR: failed to build world TB --- 2009-11-01 22:23:16 - 437.46 user 84.12 system 608.02 real http://tinderbox.freebsd.org/tinderbox-releng_8-RELENG_8-mips-mips.full From lihong at ieee.org Mon Nov 2 01:18:59 2009 From: lihong at ieee.org (Eric) Date: Mon Nov 2 01:19:05 2009 Subject: Add Wistron RPAA-82 board support In-Reply-To: <4AE92D94.2070700@freebsd.org> References: <1256528272.31398.28.camel@localhost> <20091026051144.GA89831@citylink.fud.org.nz> <1256535242.31398.32.camel@localhost> <4AE92D94.2070700@freebsd.org> Message-ID: <1257124725.3097.2.camel@localhost> On Wed, 2009-10-28 at 22:52 -0700, Oleksandr Tymoshenko wrote: > Eric wrote: > > On Mon, 2009-10-26 at 18:11 +1300, Andrew Thompson wrote: > >> On Mon, Oct 26, 2009 at 11:37:52AM +0800, Eric wrote: > >>> Hi > >>> I added my ar7161 board support last weekend. > >>> It's flash is come from Spansion. > >> This is great. Oleksandr has also just added write support which will > >> conflict/duplicate some of your changes so have a look and merge any > >> outstanding changes you have made (s25fl128 support). > >> > >> http://svn.freebsd.org/viewvc/base?view=revision&revision=198465 > >> > >> cheers, > >> Andrew > > > > At first, I have my own write support, then I saw hit commit today. > > So this patch already merged his commit. > There are some excessive code in the patch. e.g. GEOM will take care for > use that data offset and size are sector-size aligned/multiple. So I reworked > your patch a little bit: > http://people.freebsd.org/~gonzo/mips/mx25.diff > > Could you, please, test it and let me know if it works for you. > > Thanks! It cannot format redboot partition by newfs: uhub1: 2 ports with 2 removable, self powered redboot/fbsd-root.uzip: 6144 x 8192 blocks Trying to mount root from ufs:/dev/redboot/fbsd-root.uzip warning: no time-of-day clock registered, system time will not be set accurately start_init: trying /etc/init eval: cannot create /flash/hostid: Read-only file system /etc/rc: WARNING: could not store hostuuid in /flash/hostid. mount: /dev/ufs/config : No such file or directory Mounting /etc/fstab filesystems failed, startup aborted ERROR: ABORTING BOOT (sending SIGTERM to parent)! Oct 27 01:58:39 init: /bin/sh on /etc/rc terminated abnormally, going to single user mode Enter full pathname of shell or RETURN for /bin/sh: # # # df Filesystem 512-blocks Used Avail Capacity Mounted on /dev/redboot/fbsd-root.uzip 98078 62252 27980 69% / devfs 2 2 0 100% /dev # ls /dev/redboot FIS directory RedBoot config fbsd-kern fbsd-root.uzip vmlinux.bin.l7 RedBoot fbsd-data fbsd-root rootfs # newfs -n -o space -L config -O 1 -b 4096 -f 512 /dev/redboot/fbsd-data /dev/redboot/fbsd-data: 0.6MB (1280 sectors) block size 4096, fragment size 512 using 4 cylinder groups of 0.16MB, 41 blks, 96 inodes. super-block backups (for fsck -b #) at: newfs: wtfs: 20480 bytes at sector 32: Invalid argument # reboot Waiting (max 60 seconds) for system process `vnlru' to stop...done Waiting (max 60 seconds) for system process `bufdaemon' to stop...done Waiting (max 60 seconds) for system process `syncer' to stop... Syncing disks, vnodes remaining...0 0 0 0 0 0 0 0 done All buffers synced. Uptime: 3m15s Rebooting... +phyReg16Val = 1b2b phyReg20Val = d6d Ethernet eth0: MAC address 00:03:7f:ff:ff:fe IP: 192.168.1.81/255.255.255.0, Gateway: 0.0.0.0 Default server: 192.168.1.254 RedBoot(tm) bootstrap and debug environment [ROMRAM] Non-certified release, version v1.0 - built 12:26:39, May 18 2009 Copyright (C) 2000, 2001, 2002, 2003, 2004 Red Hat, Inc. Board: RPAA-82 RAM: 0x80000000-0x84000000, [0x80051290-0x80fe1000] available FLASH: 0xbf000000 - 0xbfff0000, 256 blocks of 0x00010000 bytes each. == Executing boot script in 3.000 seconds - enter ^C to abort ^C RedBoot> fis list Name FLASH addr Mem addr Length Entry point RedBoot 0xBF000000 0xBF000000 0x00040000 0x00000000 vmlinux.bin.l7 0xBF040000 0x80060000 0x00100000 0x80060000 rootfs 0xBF140000 0xBF140000 0x00400000 0x00000000 fbsd-kern 0xBF540000 0x80060000 0x00200000 0x800976C0 fbsd-root 0xBF740000 0xBF740000 0x00800000 0x00000000 fbsd-data 0xBFF40000 0xBFF40000 0x000A0000 0x00000000 FIS directory 0xBFFE0000 0xBFFE0000 0x0000F000 0x00000000 RedBoot config 0xBFFEF000 0xBFFEF000 0x00001000 0x00000000 RedBoot> From andy at fud.org.nz Mon Nov 2 01:43:41 2009 From: andy at fud.org.nz (Andrew Thompson) Date: Mon Nov 2 01:43:47 2009 Subject: Add Wistron RPAA-82 board support In-Reply-To: <1257124725.3097.2.camel@localhost> References: <1256528272.31398.28.camel@localhost> <20091026051144.GA89831@citylink.fud.org.nz> <1256535242.31398.32.camel@localhost> <4AE92D94.2070700@freebsd.org> <1257124725.3097.2.camel@localhost> Message-ID: <20091102012345.GA49898@citylink.fud.org.nz> On Mon, Nov 02, 2009 at 09:18:45AM +0800, Eric wrote: > On Wed, 2009-10-28 at 22:52 -0700, Oleksandr Tymoshenko wrote: > > There are some excessive code in the patch. e.g. GEOM will take care for > > use that data offset and size are sector-size aligned/multiple. So I reworked > > your patch a little bit: > > http://people.freebsd.org/~gonzo/mips/mx25.diff > > > > Could you, please, test it and let me know if it works for you. > > > > Thanks! > > It cannot format redboot partition by newfs: > uhub1: 2 ports with 2 removable, self powered > redboot/fbsd-root.uzip: 6144 x 8192 blocks > Trying to mount root from ufs:/dev/redboot/fbsd-root.uzip > warning: no time-of-day clock registered, system time will not be set > accurately > start_init: trying /etc/init > eval: cannot create /flash/hostid: Read-only file system > /etc/rc: WARNING: could not store hostuuid in /flash/hostid. > mount: /dev/ufs/config : No such file or directory > Mounting /etc/fstab filesystems failed, startup aborted > ERROR: ABORTING BOOT (sending SIGTERM to parent)! > Oct 27 01:58:39 init: /bin/sh on /etc/rc terminated abnormally, going to > single user mode > Enter full pathname of shell or RETURN for /bin/sh: > # > # > # df > Filesystem 512-blocks Used Avail Capacity Mounted on > /dev/redboot/fbsd-root.uzip 98078 62252 27980 69% / > devfs 2 2 0 100% /dev > # ls /dev/redboot > FIS directory RedBoot config fbsd-kern fbsd-root.uzip vmlinux.bin.l7 > RedBoot fbsd-data fbsd-root rootfs > # newfs -n -o space -L config -O 1 -b 4096 -f 512 /dev/redboot/fbsd-data > /dev/redboot/fbsd-data: 0.6MB (1280 sectors) block size 4096, fragment > size 512 > using 4 cylinder groups of 0.16MB, 41 blks, 96 inodes. > super-block backups (for fsck -b #) at: > newfs: wtfs: 20480 bytes at sector 32: Invalid argument The problem here is the flash sector size is 64k. Pretending the flash has a 512b sector isnt the right way, you would be better off having a geom class to do the transformation+caching. Andrew From lihong at ieee.org Mon Nov 2 01:45:59 2009 From: lihong at ieee.org (Eric) Date: Mon Nov 2 01:46:05 2009 Subject: Add Wistron RPAA-82 board support In-Reply-To: <20091102012345.GA49898@citylink.fud.org.nz> References: <1256528272.31398.28.camel@localhost> <20091026051144.GA89831@citylink.fud.org.nz> <1256535242.31398.32.camel@localhost> <4AE92D94.2070700@freebsd.org> <1257124725.3097.2.camel@localhost> <20091102012345.GA49898@citylink.fud.org.nz> Message-ID: <1257126338.3097.7.camel@localhost> On Mon, 2009-11-02 at 14:23 +1300, Andrew Thompson wrote: > On Mon, Nov 02, 2009 at 09:18:45AM +0800, Eric wrote: > > On Wed, 2009-10-28 at 22:52 -0700, Oleksandr Tymoshenko wrote: > > > There are some excessive code in the patch. e.g. GEOM will take care for > > > use that data offset and size are sector-size aligned/multiple. So I reworked > > > your patch a little bit: > > > http://people.freebsd.org/~gonzo/mips/mx25.diff > > > > > > Could you, please, test it and let me know if it works for you. > > > > > > Thanks! > > > > It cannot format redboot partition by newfs: > > uhub1: 2 ports with 2 removable, self powered > > redboot/fbsd-root.uzip: 6144 x 8192 blocks > > Trying to mount root from ufs:/dev/redboot/fbsd-root.uzip > > warning: no time-of-day clock registered, system time will not be set > > accurately > > start_init: trying /etc/init > > eval: cannot create /flash/hostid: Read-only file system > > /etc/rc: WARNING: could not store hostuuid in /flash/hostid. > > mount: /dev/ufs/config : No such file or directory > > Mounting /etc/fstab filesystems failed, startup aborted > > ERROR: ABORTING BOOT (sending SIGTERM to parent)! > > Oct 27 01:58:39 init: /bin/sh on /etc/rc terminated abnormally, going to > > single user mode > > Enter full pathname of shell or RETURN for /bin/sh: > > # > > # > > # df > > Filesystem 512-blocks Used Avail Capacity Mounted on > > /dev/redboot/fbsd-root.uzip 98078 62252 27980 69% / > > devfs 2 2 0 100% /dev > > # ls /dev/redboot > > FIS directory RedBoot config fbsd-kern fbsd-root.uzip vmlinux.bin.l7 > > RedBoot fbsd-data fbsd-root rootfs > > # newfs -n -o space -L config -O 1 -b 4096 -f 512 /dev/redboot/fbsd-data > > /dev/redboot/fbsd-data: 0.6MB (1280 sectors) block size 4096, fragment > > size 512 > > using 4 cylinder groups of 0.16MB, 41 blks, 96 inodes. > > super-block backups (for fsck -b #) at: > > newfs: wtfs: 20480 bytes at sector 32: Invalid argument > > The problem here is the flash sector size is 64k. Pretending the flash > has a 512b sector isnt the right way, you would be better off having a > geom class to do the transformation+caching. > > > Andrew So, the better way is that add a new geom class to support different erase and program size? I referred XOR flash sys/dev/cfi/cfi_disk.c at first. It set disk sector size to 512 even erase size is 128k. -- Best Regards, Eric L. Chen From imp at bsdimp.com Mon Nov 2 04:17:04 2009 From: imp at bsdimp.com (M. Warner Losh) Date: Mon Nov 2 04:17:11 2009 Subject: Add Wistron RPAA-82 board support In-Reply-To: <1257126338.3097.7.camel@localhost> References: <1257124725.3097.2.camel@localhost> <20091102012345.GA49898@citylink.fud.org.nz> <1257126338.3097.7.camel@localhost> Message-ID: <20091101.210843.-726381605.imp@bsdimp.com> In message: <1257126338.3097.7.camel@localhost> Eric writes: : On Mon, 2009-11-02 at 14:23 +1300, Andrew Thompson wrote: : > On Mon, Nov 02, 2009 at 09:18:45AM +0800, Eric wrote: : > > On Wed, 2009-10-28 at 22:52 -0700, Oleksandr Tymoshenko wrote: : > > > There are some excessive code in the patch. e.g. GEOM will take care for : > > > use that data offset and size are sector-size aligned/multiple. So I reworked : > > > your patch a little bit: : > > > http://people.freebsd.org/~gonzo/mips/mx25.diff : > > > : > > > Could you, please, test it and let me know if it works for you. : > > > : > > > Thanks! : > > : > > It cannot format redboot partition by newfs: : > > uhub1: 2 ports with 2 removable, self powered : > > redboot/fbsd-root.uzip: 6144 x 8192 blocks : > > Trying to mount root from ufs:/dev/redboot/fbsd-root.uzip : > > warning: no time-of-day clock registered, system time will not be set : > > accurately : > > start_init: trying /etc/init : > > eval: cannot create /flash/hostid: Read-only file system : > > /etc/rc: WARNING: could not store hostuuid in /flash/hostid. : > > mount: /dev/ufs/config : No such file or directory : > > Mounting /etc/fstab filesystems failed, startup aborted : > > ERROR: ABORTING BOOT (sending SIGTERM to parent)! : > > Oct 27 01:58:39 init: /bin/sh on /etc/rc terminated abnormally, going to : > > single user mode : > > Enter full pathname of shell or RETURN for /bin/sh: : > > # : > > # : > > # df : > > Filesystem 512-blocks Used Avail Capacity Mounted on : > > /dev/redboot/fbsd-root.uzip 98078 62252 27980 69% / : > > devfs 2 2 0 100% /dev : > > # ls /dev/redboot : > > FIS directory RedBoot config fbsd-kern fbsd-root.uzip vmlinux.bin.l7 : > > RedBoot fbsd-data fbsd-root rootfs : > > # newfs -n -o space -L config -O 1 -b 4096 -f 512 /dev/redboot/fbsd-data : > > /dev/redboot/fbsd-data: 0.6MB (1280 sectors) block size 4096, fragment : > > size 512 : > > using 4 cylinder groups of 0.16MB, 41 blks, 96 inodes. : > > super-block backups (for fsck -b #) at: : > > newfs: wtfs: 20480 bytes at sector 32: Invalid argument : > : > The problem here is the flash sector size is 64k. Pretending the flash : > has a 512b sector isnt the right way, you would be better off having a : > geom class to do the transformation+caching. : > : > : > Andrew : : So, the better way is that add a new geom class to support different : erase and program size? : I referred XOR flash sys/dev/cfi/cfi_disk.c at first. It set disk sector : size to 512 even erase size is 128k. Yea. That's not quite right... when I did the spi flash, I exported the actual write sector size. on SPI flash, however, you don't have to erase it: the controller will do that for you (it is less efficient, however). We do need to have a good geom layer that does this. We also need a good flash file system as well... Warner From peterc at blipcreative.com Sun Nov 15 18:18:58 2009 From: peterc at blipcreative.com (peter cornwell) Date: Sun Nov 15 18:19:05 2009 Subject: Second hand video equipment for sale. Message-ID: <4B004308.4010602@blipcreative.com> hi do you have an FPD-400 demand focus for Canon for sale at the moment? best, peterc From tinderbox at freebsd.org Wed Nov 18 03:27:14 2009 From: tinderbox at freebsd.org (FreeBSD Tinderbox) Date: Wed Nov 18 03:27:21 2009 Subject: [head tinderbox] failure on mips/mips Message-ID: <200911180327.nAI3RDPT097293@freebsd-current.sentex.ca> TB --- 2009-11-18 02:40:23 - tinderbox 2.6 running on freebsd-current.sentex.ca TB --- 2009-11-18 02:40:23 - starting HEAD tinderbox run for mips/mips TB --- 2009-11-18 02:40:23 - cleaning the object tree TB --- 2009-11-18 02:40:32 - cvsupping the source tree TB --- 2009-11-18 02:40:32 - /usr/bin/csup -z -r 3 -g -L 1 -h cvsup.sentex.ca /tinderbox/HEAD/mips/mips/supfile TB --- 2009-11-18 02:40:57 - building world TB --- 2009-11-18 02:40:57 - MAKEOBJDIRPREFIX=/obj TB --- 2009-11-18 02:40:57 - PATH=/usr/bin:/usr/sbin:/bin:/sbin TB --- 2009-11-18 02:40:57 - TARGET=mips TB --- 2009-11-18 02:40:57 - TARGET_ARCH=mips TB --- 2009-11-18 02:40:57 - TZ=UTC TB --- 2009-11-18 02:40:57 - __MAKE_CONF=/dev/null TB --- 2009-11-18 02:40:57 - cd /src TB --- 2009-11-18 02:40:57 - /usr/bin/make -B buildworld >>> World build started on Wed Nov 18 02:40:58 UTC 2009 >>> Rebuilding the temporary build tree >>> stage 1.1: legacy release compatibility shims >>> stage 1.2: bootstrap tools >>> stage 2.1: cleaning up the object tree >>> stage 2.2: rebuilding the object tree >>> stage 2.3: build tools >>> stage 3: cross tools >>> stage 4.1: building includes >>> stage 4.2: building libraries >>> stage 4.3: make dependencies >>> stage 4.4: building everything [...] cc -O -pipe -EL -msoft-float -G0 -mno-dsp -mabicalls -I/src/usr.sbin/ntp/ntpd/../../../contrib/ntp/include -I/src/usr.sbin/ntp/ntpd/../ -I/src/usr.sbin/ntp/ntpd/../../../contrib/ntp/libopts -I/src/usr.sbin/ntp/ntpd -DSYS_FREEBSD -DPARSE -DHAVE_CONFIG_H -DOPENSSL -std=gnu99 -c /src/usr.sbin/ntp/ntpd/../../../contrib/ntp/ntpd/refclock_ulink.c cc -O -pipe -EL -msoft-float -G0 -mno-dsp -mabicalls -I/src/usr.sbin/ntp/ntpd/../../../contrib/ntp/include -I/src/usr.sbin/ntp/ntpd/../ -I/src/usr.sbin/ntp/ntpd/../../../contrib/ntp/libopts -I/src/usr.sbin/ntp/ntpd -DSYS_FREEBSD -DPARSE -DHAVE_CONFIG_H -DOPENSSL -std=gnu99 -c /src/usr.sbin/ntp/ntpd/../../../contrib/ntp/ntpd/refclock_wwv.c cc -O -pipe -EL -msoft-float -G0 -mno-dsp -mabicalls -I/src/usr.sbin/ntp/ntpd/../../../contrib/ntp/include -I/src/usr.sbin/ntp/ntpd/../ -I/src/usr.sbin/ntp/ntpd/../../../contrib/ntp/libopts -I/src/usr.sbin/ntp/ntpd -DSYS_FREEBSD -DPARSE -DHAVE_CONFIG_H -DOPENSSL -std=gnu99 -c /src/usr.sbin/ntp/ntpd/../../../contrib/ntp/ntpd/refclock_wwvb.c cc -O -pipe -EL -msoft-float -G0 -mno-dsp -mabicalls -I/src/usr.sbin/ntp/ntpd/../../../contrib/ntp/include -I/src/usr.sbin/ntp/ntpd/../ -I/src/usr.sbin/ntp/ntpd/../../../contrib/ntp/libopts -I/src/usr.sbin/ntp/ntpd -DSYS_FREEBSD -DPARSE -DHAVE_CONFIG_H -DOPENSSL -std=gnu99 -c /src/usr.sbin/ntp/ntpd/../../../contrib/ntp/ntpd/ntpd-opts.c cc -O -pipe -EL -msoft-float -G0 -mno-dsp -mabicalls -I/src/usr.sbin/ntp/ntpd/../../../contrib/ntp/include -I/src/usr.sbin/ntp/ntpd/../ -I/src/usr.sbin/ntp/ntpd/../../../contrib/ntp/libopts -I/src/usr.sbin/ntp/ntpd -DSYS_FREEBSD -DPARSE -DHAVE_CONFIG_H -DOPENSSL -std=gnu99 -c version.c cc -O -pipe -EL -msoft-float -G0 -mno-dsp -mabicalls -I/src/usr.sbin/ntp/ntpd/../../../contrib/ntp/include -I/src/usr.sbin/ntp/ntpd/../ -I/src/usr.sbin/ntp/ntpd/../../../contrib/ntp/libopts -I/src/usr.sbin/ntp/ntpd -DSYS_FREEBSD -DPARSE -DHAVE_CONFIG_H -DOPENSSL -std=gnu99 -Wl,-EL -o ntpd cmd_args.o ntp_config.o ntp_control.o ntp_crypto.o ntp_filegen.o ntp_intres.o ntp_io.o ntp_loopfilter.o ntp_monitor.o ntp_peer.o ntp_proto.o ntp_refclock.o ntp_request.o ntp_restrict.o ntp_timer.o ntp_util.o ntpd.o refclock_acts.o refclock_arbiter.o refclock_arc.o refclock_as2201.o refclock_atom.o refclock_bancomm.o refclock_chronolog.o refclock_chu.o refclock_conf.o refclock_datum.o refclock_dumbclock.o refclock_fg.o refclock_gpsvme.o refclock_heath.o refclock_hopfpci.o refclock_hopfser.o refclock_hpgps.o refclock_irig.o refclock_jupiter.o refclock_leitch.o refclock_local.o refclock_msfees.o refclock_mx4200.o refclock_neoclock4x.o refclock_nmea.o refclock_oncore.o refclock_palisade.o ! refclock_parse.o refclock_pcf.o refclock_pst.o refclock_ripencc.o refclock_shm.o refclock_tpro.o refclock_trak.o refclock_true.o refclock_ulink.o refclock_wwv.o refclock_wwvb.o ntpd-opts.o version.o /obj/mips/src/usr.sbin/ntp/ntpd/../libparse/libparse.a /obj/mips/src/usr.sbin/ntp/ntpd/../libntp/libntp.a -lm -lmd -lrt /obj/mips/src/usr.sbin/ntp/ntpd/../libopts/libopts.a -lcrypto /obj/mips/src/tmp/usr/lib/librt.so: undefined reference to `__pthread_cleanup_pop_imp' /obj/mips/src/tmp/usr/lib/librt.so: undefined reference to `__pthread_cleanup_push_imp' *** Error code 1 Stop in /src/usr.sbin/ntp/ntpd. *** Error code 1 Stop in /src/usr.sbin/ntp. *** Error code 1 Stop in /src/usr.sbin. *** Error code 1 Stop in /src. *** Error code 1 Stop in /src. *** Error code 1 Stop in /src. TB --- 2009-11-18 03:27:13 - WARNING: /usr/bin/make returned exit code 1 TB --- 2009-11-18 03:27:13 - ERROR: failed to build world TB --- 2009-11-18 03:27:13 - 1980.57 user 474.63 system 2809.70 real http://tinderbox.freebsd.org/tinderbox-head-HEAD-mips-mips.full From jhb at freebsd.org Thu Nov 19 20:30:49 2009 From: jhb at freebsd.org (John Baldwin) Date: Thu Nov 19 20:30:56 2009 Subject: [PATCH] Remove if_watchdog use In-Reply-To: <200911061508.22482.jhb@freebsd.org> References: <200911061508.22482.jhb@freebsd.org> Message-ID: <200911191530.39924.jhb@freebsd.org> On Friday 06 November 2009 3:08:22 pm John Baldwin wrote: > I have a patchset that converts all the remaining users of if_watchdog to > using a private callout instead. In some cases the the driver already used a > private timer to drive a stats timer and I merely hooked into that timer. In > other cases a new callout needed to be added to the driver. Some drivers > even abused the if_watchdog interface to provide a stats timer that fired > every second. :) For a few drivers I also fixed other things such as busted > locking, order-of-operations issues in detach, or just completely busted > drivers (fea(4) and fpa(4) which share the pdq backend). Please test. > Barring any major screaming and shouting I plan to commit this in a week or > so and after that to work on removing the if_watchdog/if_timer stuff from the > network stack. > > The patch is at http://www.FreeBSD.org/~jhb/patches/cleanup.patch > > Driver details: > - admsw(4) > - This driver is a bit special in that it has no locking at all, not even > a poor attempt. :) It also appears to be for a specific MIPS board of > some sort. > - It has multiple ifnet's for multiple ports, but it only used if_timer and > if_watchdog from the first ifnet. For this driver I added a single > private timer to replace the if_timer use on the first ifnet. I marked > the callout MPSAFE, but the driver really needs to have locking added at > which point it could use callout_init_mtx(). Can someone please review the changes to this driver? Also, the driver could really use some love in the form of adding locking. -- John Baldwin