openjdk6: Compiler-gcc.gmk patching vs non-base compiler

Andriy Gapon avg at FreeBSD.org
Mon Jun 11 16:18:38 UTC 2012


patch-set adds blocks of definitions for bsd case to
jdk/make/common/shared/Compiler-gcc.gmk and
corba/make/common/shared/Compiler-gcc.gmk that look like this:
+ifeq ($(PLATFORM), bsd)
+
+  # Settings specific to BSD
+  CC             = $(COMPILER_PATH)gcc
+  CPP            = $(COMPILER_PATH)gcc -E
+  CXX            = $(COMPILER_PATH)g++
...

These assignments completely override CC/CXX/etc settings provided via MAKE_ENV.
I think that they should be conditional assignments (?=).
I've already tested such a change and it worked fine for compiling the port with
gcc46.


-- 
Andriy Gapon



More information about the freebsd-java mailing list