[Fwd: portlint and USE_ANT]

[Greg Lewis]

On Sun, Dec 07, 2008 at 11:38:04AM -0500, Joe Marcus Clarke wrote:
> I received this email from a user.  Is this the correct change to make
> to portlint?

I didn't see an attached change, but it looks like the FATAL should be
turned into a WARNING.  So if thats what you meant then I would agree.
Certainly defining do-build when you have set USE_ANT is normally a bug,
so portlint should continue to do something in that situation, but a
FATAL looks to be too restrictive.  I took a look at the port in question
and the usage looked fine to me.

Content-Description: Forwarded message - portlint and USE_ANT
> Delivered-To: marcus at freebsd.org
> Date: Mon, 01 Dec 2008 10:07:49 +0100
> From: Dominic Fandrey <kamikaze at bsdforen.de>
> User-Agent: Thunderbird 2.0.0.18 (X11/20081123)
> To: marcus at FreeBSD.org
> Subject: portlint and USE_ANT
> X-Enigmail-Version: 0.95.7
> X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=ham
> 	version=3.2.5
> X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on
> 	creme-brulee.marcuscom.com
> 
> Portlint issues a FATAL message about USE_ANT for a port of mine:
> 
> # cd /usr/ports/java/phpeclipse
> # portlint ./
> FATAL: Makefile: USE_ANT is intended only for ports that build with Ant.  You should not override ``do-build'' when defining USE_ANT
> 1 fatal error and 0 warnings found.
> 
> In my opinion my use of USE_ANT is correct, though. This is from
> bsd.java.mk:
> 
> > USE_ANT
> > Should be defined when the port uses Apache Ant. Ant is thus
> > considered to be the sub-make command. When no 'do-build'
> > target is defined by the port, a default one will be set
> > that simply runs Ant according to MAKE_ENV, MAKE_ARGS and
> > ALL_TARGET. Read the documentation in bsd.port.mk for more
> > information.
> 
> This explicitly states the possibility of defining your own
> do-build target.
> 
> The FATAL error keeps me from running 'port test'.
> 
> Regards,
> Dominic
> 




-- 
Greg Lewis                          Email   : glewis at eyesbeyond.com
Eyes Beyond                         Web     : http://www.eyesbeyond.com
Information Technology              FreeBSD : glewis at FreeBSD.org