[patch] Install a desktop icon for the jdk15 Control Panel

Panagiotis Astithas past at ebs.gr
Sat Oct 1 13:36:12 PDT 2005


Greg Lewis wrote:
> Hi Panagiotis,
> 
> On Thu, Sep 29, 2005 at 10:30:46AM +0300, Panagiotis Astithas wrote:
> 
>>Greg Lewis wrote:
>>
>>>Hi Panagiotis,
>>>
>>>On Thu, Sep 29, 2005 at 12:09:16AM +0300, Panagiotis Astithas wrote:
>>>
>>>
>>>>I cooked up this patch to fix something that has been annoying me for a 
>>>>long time. When we install the jdk we don't fix the provided 
>>>>sun_java.desktop file, or install it in a suitable place for desktop 
>>>>environments to pick up. This patch is for jdk15 and creates the 
>>>>necessary menu entry for Gnome and KDE (although I haven't tested on the 
>>>>latter). It should be trivial to make the same changes for jdk14, by 
>>>>using MINIMAL instead of WITHOUT_WEB.
>>>
>>>
>>>Thanks working this up.  Can you please send-pr it?  I'm worried that
>>>it will get lost otherwise since I'm currently tracking some other patches
>>>as well.
>>
>>Certainly.
> 
> 
> Thanks!

It is PR java/86804.

>>>It would be good if someone could test your changes against KDE as well.
>>>
>>>I have some minor comments on the patch.
>>>
>>>
>>>
>>>>--- /usr/ports/java/jdk15/Makefile	Tue Sep 20 23:00:08 2005
>>>>+++ jdk15/Makefile	Wed Sep 28 23:57:17 2005
>>>>@@ -43,6 +43,7 @@
>>>>MAKE_ENV+=	BROWSER=mozilla
>>>>.endif
>>>>USE_ICONV=	yes
>>>>+USE_GNOME=	desktopfileutils
>>>
>>>
>>>Does this pull in any extra dependencies other than desktop-file-utils?
>>>the jdk is already pretty fat with dependencies, and I particularly don't
>>>want to pull in a bunch of KDE and/or Gnome dependencies.
>>
>>I don't think so, I used it as a convenience, since desktopfileutils 
>>itself contains a 'USE_GNOME=glib20' line. So I figured, if you have 
>>that, you had glib20 at least. I guess a tester with KDE will let us 
>>know for sure.
> 
> 
> Ok, good.  I think glib20 is an acceptable extra dependency :).

Desktopfileutils is actually a dependency from mozilla, as I was 
informed by the freebsd-gnome team. They also suggested that I keep it, 
probably to make it more explicit and future-proof.

>>Initially I had it in the post-install step, but I thought an extra 
>>ifdef there, would be considered uglier than this :-)
> 
> 
> My feeling on it is that an operation like this is a post-install
> operation rather than an install operation since it would appear to
> be updating an external "database" of some sort.  If updating that
> database is important, then the operation should actually be done
> in the pkg-install script (or installing a package will mean that
> the database isn't updated).
> 
> However, you mention that this step is done in Makefiles for other
> ports.  That leads me to believe that either these ports are all broken
> in terms of being installed as a package (not inconceivable ;) or this
> operation doesn't actually do anything important.  I think we need
> to determine which it is so we can do the right thing here.
> 
> Thanks for working on this!
> 

I moved it as you suggested. It seems most other ports have it there, 
too. If this step is skipped, the worst thing that will happen is that 
the menu update will have to wait for the next login.

Regards,

Panagiotis


More information about the freebsd-java mailing list