xalan-j and Java-1.5

[Herve Quiroz]

Hi Mikhail,

On Thu, Jul 07, 2005 at 12:52:32AM -0400, Mikhail T. wrote:
> According to http://java.sun.com/j2se/1.5.0/compatibility.html ,
> Java-1.5 comes with Xerces from Apache, so there is no need to build it
> for Xalan's sake if the used Java is of version 1.5
> 
> In addition, the xerces-j would not build with 1.5 anyway :-)
> 
> Below is a patch for xalan-j -- please, commit or allow me to do so.
> There is no need to bump portrevision, because the currently existin
> package(s) will not change.

You're right about the Xerces vs JDK 1.5 issue. I think I mentioned it
in my last commit log. Anyway, here is the build output when using your
patch:


$ make -DUSE_JIKES=no JAVA_PREFERRED_PORTS=JAVA_PORT_NATIVE_BSDJAVA_JDK_1_5
===>  Building for xalan-j-2.6.0
Buildfile: build.xml

prepare:
     [echo] Project:Xalan-Java version:2_6_0 build.xml $Revision: 1.206 $

xml.compile:
     [echo] Compiling DTM implementation and utilities
    [javac] Compiling 3 source files to /tmp/xalan-j/work/xalan-j_2_6_0/build/classes
    [javac] javac: target release 1.1 conflicts with default source release 1.5

BUILD FAILED
/tmp/xalan-j/work/xalan-j_2_6_0/build.xml:256: Compile failed; see the compiler error output for details.

Total time: 4 seconds
*** Error code 1

Stop in /tmp/xalan-j.


So we will need some more tweaking here if we want Xalan-J to work with
JDK 1.5. I agree with you anyway: we need to fix this. I'll have another
look at this ASAP.

BTW, I suggest using the following macro to get the JDK version
(documented in bsd.java.mk header):

> +.if empty(JAVA_HOME:M*1.5*)
> +RUN_DEPENDS+=	${JAVALIBDIR}/xml-apis.jar:${PORTSDIR}/textproc/xerces-j
> +.endif
> +

==> .if "${JAVA_PORT_VERSION:C/^([0-9])\.([0-9])(.*)$/\1.\2/}" == "1.5"

Herve