Assertion failure while compiling jdk14

[Greg Lewis]

On Thu, Oct 30, 2003 at 05:30:24PM -0500, Christopher Rued wrote:
> Greg Lewis wrote:
> 
> >Look at j2se/make/common/Defs.gmk.  It currently contains the patch to
> >set javah_g to javah on BSD.  Try adding a similar thing for the JAVAC
> >variable.
> >
> I did what you said (here's a patch showing what I changed):
> 
> --- j2se/make/common/Defs.gmk~  Wed Oct 29 16:42:00 2003
> +++ j2se/make/common/Defs.gmk   Thu Oct 30 16:41:03 2003
> @@ -464,6 +464,7 @@
>   # --phantom
>   ifeq ($(PLATFORM), bsd)
>     JAVAH_CMD = $(BINDIR)/javah
> +    JAVAC_CMD = $(BINDIR)/javac
>   endif
>   RMIC         = $(BINDIR)/rmic$(SUFFIX)
> endif

Thats not quite right.  You need to redefine JAVAC, not JAVAC_CMD.

> And then I ran `make install` from /usr/ports/java/jdk14.  It still 
> tries to use javac_g, and it still fails in exactly the same way :-(.
> I didn't run make clean first, but as far as I can tell, that shouldn't 
> make a difference.  I'm browing Makefiles and .gmk files right now
> trying to figure out why this change didn't seem to take hold.
>
> Does the patch look right to you?
> Do I need to do a `make clean`, `make patch`, apply my patch, and *then* 
> `make install`?

Depends how you are doing the patch.  It sounds like you're just editing
the file, so you probably don't need a make clean.  If you were sticking
the patch into the files directory then you would need to.

-- 
Greg Lewis                          Email   : glewis at eyesbeyond.com
Eyes Beyond                         Web     : http://www.eyesbeyond.com
Information Technology              FreeBSD : glewis at FreeBSD.org