jdk14 patches

Greg Lewis glewis at eyesbeyond.com
Thu Oct 9 07:01:47 PDT 2003


Hi Haro-san,

On Thu, Oct 09, 2003 at 06:25:15PM +0900, Munehiro Matsuda wrote:
> Good work, as always. :-)
> 
> But grancing through your patches, I'm not sure I like the
> following part, which tries to work around the '_LITTLE_ENDIAN'
> problem. This change may hide other errors, that may cause
> more trouble in the future.

I agree.  I don't intend to commit this patch to the project repository,
but it was the simplest patch to get people going with the port.

> I use the following patch myself. I don't like my patch, neither. ;-)
> But better show errors, than hide them away.
> 
> ---8<------8<------8<--- patch-zharo-common::Defs-bsd.gmk ---8<------8<----
> --- ../../j2se/make/common/Defs-bsd.gmk.org	Wed Oct  8 09:31:35 2003
> +++ ../../j2se/make/common/Defs-bsd.gmk	Mon Oct  6 20:33:00 2003
> @@ -277,7 +277,13 @@
>  CXXFLAGS_DBG	= -g
>  
>  CPPFLAGS_COMMON = -D$(ARCH) -DARCH='"$(ARCH)"' $(VERSION_DEFINES) \
> -		  -D_GNU_SOURCE -D_REENTRANT -D_THREAD_SAFE -D_LITTLE_ENDIAN
> +		  -D_GNU_SOURCE -D_REENTRANT -D_THREAD_SAFE
> +
> +ifeq ($(TRUE_PLATFORM), FreeBSD)
> +CPPFLAGS_COMMON += -D_LITTLE_ENDIAN=1234
> +else
> +CPPFLAGS_COMMON += -D_LITTLE_ENDIAN
> +endif
>  
>  ifeq ($(ARCH_DATA_MODEL), 64)
>  CPPFLAGS_COMMON += -D_LP64=1

I have a different patch I was intending to commit.  It removes the setting
of -D_LITTLE_ENDIAN at all and uses <endian.h> to replace its usage in the
appropriate files.  That is what ended up being done in 1.3, so I was just
going to do the same in 1.4 (Alexey asked me to hold off until after
patchset 4 though).  Comments?

-- 
Greg Lewis                          Email   : glewis at eyesbeyond.com
Eyes Beyond                         Web     : http://www.eyesbeyond.com
Information Technology              FreeBSD : glewis at FreeBSD.org



More information about the freebsd-java mailing list