kern/177948: [ipfw] ipfw fails to parse port ranges (p1-p2) for udp

Jukka Ukkonen jau at oxit.fi
Sun Apr 21 12:40:01 UTC 2013


The following reply was made to PR kern/177948; it has been noted by GNATS.

From: Jukka Ukkonen <jau at oxit.fi>
To: Ian Smith <smithi at nimnet.asn.au>
Cc: bug-followup at FreeBSD.org
Subject: Re: kern/177948: [ipfw] ipfw fails to parse port ranges (p1-p2) for
 udp
Date: Sun, 21 Apr 2013 15:33:03 +0300

 On 04/21/13 15:21, Ian Smith wrote:
 > On Sun, 21 Apr 2013 14:33:07 +0300, Jukka Ukkonen wrote:
 >  > On 04/21/13 05:17, Ian Smith wrote:
 >  > > I can't reproduce this on 9.1-RELEASE, unless I put a space anywhere
 >  > > amongst p1, '-' and p2, in which case I see the same error you show.
 > [..]
 >
 >  > Right,
 >  > 
 >  > After some further inspection I have news...
 >  > 
 >  > This seems to be a problem in clang-cpp which adds an extra space
 >  > before the dash in a macro which should have a value of the format
 >  > "number1-number2". So, e.g. "1024-65535" becomes "1024 -65535".
 >
 > Naughty clang!  For one thing, that's emitting two values ..
 >
 >  > If I use gcpp instead, everything works just fine with ipfw.
 >  > 
 >  > The fact that I did not see this happening with TCP rules as well was
 >  > just lucky coincidence.
 >  > 
 >  > So, this is a clang problem, not an ipfw problem!!!
 >  > 
 >  > Cheers,
 >  > --jau
 >
 > Good news for ipfw, anyway.  I don't know the correct form .. should 
 > this PR be reassigned, or closed with a reference in a fresh clang PR?
 >
 > cheers, Ian
 
 Please, try reassigning first.
 This is anyhow a pretty clear issue. If the clang experts then
 wish to have a separate fresh PR for clang, they can close
 this one and request a new PR.
 
 Cheers,
 --jau
 


More information about the freebsd-ipfw mailing list