src-limit trouble

[Mihail Balikov]

I was incorrect, problem appears when you have a lot of PARENT with single
static rule . Here you are , avery simple patch for 4.8

regards,
Mihail

--- ip_fw2.c.orig Sun May  4 11:44:42 2003
+++ ip_fw2.c Sun May  4 11:49:22 2003
@@ -682,10 +682,14 @@
     max_pass = 1;
     if (pass == 0)
      goto next;
-    if (FORCE && q->count != 0 ) {
-     /* XXX should not happen! */
-     printf( "OUCH! cannot remove rule,"
-          " count %d\n", q->count);
+    if (q->count != 0) {
+     if (FORCE) {
+      /* XXX should not happen! */
+      printf( "OUCH! cannot remove rule,"
+           " count %d\n", q->count);
+     } else {
+      goto next;
+     }
     }
    } else {
     if (!FORCE &&


----- Original Message -----
From: <maxes at peterlink.ru>
To: "Mihail Balikov" <misho at interbgc.com>
Cc: <freebsd-ipfw at freebsd.org>
Sent: Sunday, May 04, 2003 10:53 AM
Subject: Re: src-limit trouble


> > this happens when you have more than one rule with "limit" .
> What exactly  happens  -  LIMIT without PARENT or FIN_WAIT_2 problem ?
> I use only one limit rule:
> ipfw sh | grep limit | wc -l
> 1
> >
> > I have small patch for 4.7
> Can you send it to me or to list ?
>
> b.r.
>  Kozin Maxim
>
>
>