FWSPA

[Marcel Moolenaar]

On Feb 14, 2005, at 6:39 AM, Christian Kandeler wrote:

> Hi,
>
> in the ia64_init() function, the fpswa is initialized as follows:
>
>     fpswa_interface = 
> (FPSWA_INTERFACE*)IA64_PHYS_TO_RR7(bootinfo.bi_fpswa);
>
> Shouldn't it be tested here whether bootinfo.bi_fpswa is NULL? It 
> would make
> the follwing test in cpu_startup() much more meaningful:
>
> 	if (fpswa_interface == NULL)
> 		printf("Warning: no FPSWA package supplied\n");
> 	else
> 		printf("FPSWA Revision = 0x%lx, Entry = %p\n",
> 		    (long)fpswa_interface->Revision,
> 		    (void *)fpswa_interface->Fpswa);
>
> As of now, this will always execute the else branch, because 
> bootinfo.bi_fpswa
> was unconditionally or'ed with 7 << 61 and the result can therefore 
> not be
> NULL.
> Or am I missing something?

No, you're absolutely right. Can you file a PR so that we don't forget
about it? A patch would do as well ;-)

Thanks,

-- 
  Marcel Moolenaar         USPA: A-39004          marcel at xcllnt.net