i386/46113: [bus] [patch] busspace bugs in parameter checking

Hans Petter Selasky hselasky at c2i.net
Mon Sep 11 06:32:00 PDT 2006


On Monday 11 September 2006 14:17, Remko Lodder wrote:
> Synopsis: [bus] [patch] busspace bugs in parameter checking
>
> State-Changed-From-To: open->feedback
> State-Changed-By: remko
> State-Changed-When: Mon Sep 11 12:16:49 UTC 2006
> State-Changed-Why:
> Hello,
>
> can you tell me whether this had been resolved or not
> already? Thanks!
>
>
> Responsible-Changed-From-To: freebsd-i386->remko
> Responsible-Changed-By: remko
> Responsible-Changed-When: Mon Sep 11 12:16:49 UTC 2006
> Responsible-Changed-Why:
> grab the pr
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=46113

Last time this was discussed, it ended something like this:

If the code currently never calls these functions with "count == 0", 
then assume it is an optimization to not check for "count == 0".

The isssue has not been resolved, rather worked around, by having:

if (count != 0) {
  bus_space_xxxx(....);
}

in the drivers in question.

--HPS


More information about the freebsd-i386 mailing list