Ctype patch for review

Petr Hroudný petr.hroudny at gmail.com
Fri Sep 21 00:04:46 PDT 2007


2007/9/21, Andrey Chernov <ache at nagual.pp.ru>:
> On Wed, Sep 19, 2007 at 04:10:24PM +0400, Andrey Chernov wrote:
> > Improved vesrsion. Intoduce general __mb_sch_limit parameter instead for
> > all locales specifying upper limit of single char range. It allows also
> > fix the bug when ctype(3) functions called with arg > 0xFF for wide
> > character locales and simplifies all checks. New patch is attached. Here
> > is updated rationale again:
>
> Next improved version, now optimized for speed. I decide to remove extra
> _CTYPE_WID flag and duplicate needed functions instead.

I believe your patch needs some adjustments for CJK charsets. You are setting
__mb_sch_limit to 256 for all multibyte locales except UTF-8, but I believe it
should be 128 also for Big5, GB18030, GBK.

Regards, Petr


More information about the freebsd-i18n mailing list