Fix for Logitech DiNovo cordless mouse [PATCH]

Markus Wild mwild at vianetworks.ch
Sat Jun 12 12:46:50 GMT 2004


Hm, I had a look through the patched files, and one thing that sprung
to my eyes: the FreeBSD hid_report_size(() function is currently used
to both return the size of a report, as well as setting the device
report ID (the ID parameter is of type "out"). This ID is later used
to match incoming reports to the device. With the suggested
changes, this parameter changes to being of type "in", i.e. the 
function no longer returns the ID information to the calling function.
This would certainly generate a compile time warning (if not error)
for ums.c, and while uhid.c has been syntactically changed, I now see
no place where sc->sc_iid, sc->sc_oid, sc->sc_fid would be initialized
after applying the change. I assume the NetBSD code in itself is sound,
so perhaps we're just missing additional files now that would also need
to be changed for FreeBSD?

Cheers,
Markus


More information about the freebsd-hardware mailing list