[PATCH 5/5] kern/kern_linker.c: Use correct type for sizeof() in malloc()

Conrad Meyer cemeyer at uw.edu
Wed Mar 12 00:20:11 UTC 2014


Another one reported by Clang static analysis. Again, both are pointer
types, so it's not a huge deal. Just fix it for correctness.

Signed-off-by: Conrad Meyer <conrad.meyer at isilon.com>
---
 sys/kern/kern_linker.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/sys/kern/kern_linker.c b/sys/kern/kern_linker.c
index fa09b3f..7d2aa50 100644
--- a/sys/kern/kern_linker.c
+++ b/sys/kern/kern_linker.c
@@ -725,14 +725,13 @@ linker_file_add_dependency(linker_file_t file, linker_file_t dep)
 	linker_file_t *newdeps;
 
 	sx_assert(&kld_sx, SA_XLOCKED);
-	newdeps = malloc((file->ndeps + 1) * sizeof(linker_file_t *),
-	    M_LINKER, M_WAITOK | M_ZERO);
+	newdeps = malloc((file->ndeps + 1) * sizeof(*newdeps), M_LINKER,
+	    M_WAITOK | M_ZERO);
 	if (newdeps == NULL)
 		return (ENOMEM);
 
 	if (file->deps) {
-		bcopy(file->deps, newdeps,
-		    file->ndeps * sizeof(linker_file_t *));
+		bcopy(file->deps, newdeps, file->ndeps * sizeof(*newdeps));
 		free(file->deps, M_LINKER);
 	}
 	file->deps = newdeps;
-- 
1.8.5.3



More information about the freebsd-hackers mailing list