Loader forth changes for customization

Teske, Devin Devin.Teske at fisglobal.com
Thu Nov 14 16:21:07 UTC 2013


On Nov 13, 2013, at 4:58 PM, Teske, Devin wrote:
> 
> On Nov 13, 2013, at 10:58 AM, Alfred Perlstein wrote:
>> 
>> On 11/13/13, 10:01 AM, Jordan Hubbard wrote:
>>> 
>>> On Nov 13, 2013, at 6:57 AM, Alfred Perlstein <alfred at freebsd.org> wrote:
>>> 
>>>> It seems to work although I will talk to the team about making separate files for the set commands.
>>> 
>>> Since we’re talking about this, there is an old maxim amongst FORTH programmers that if a single word’s 
>>> definition takes more than a page, it’s just too dang long.   There are some solid reasons for that, namely the fact that forth is already hard enough to read as it is (and I’m speaking as a FAN of the language) and you generally need to keep the “internal stack state” in your head while writing a word since the stack contract is only at word boundaries (e.g. word is defined as tacking stack parameters foo and returning stack parameters bar).   Keeping the definitions short and sweet really helps to aid in comprehension.
>>> 
>>> The definition for draw-beastie currently violates that maxim, and if you guys were to refactor it as part of this work, I’m sure future generations would not object! :)
>> 
>> I'll give that a shot shortly.
>> 
> 

Here's a patch to address that specifically...

https://github.com/devinteske/freebsd/commit/c07adb2a17140d52a996ea6b8ddd949b3c08be1b
-or-
https://github.com/devinteske/freebsd/commit/c07adb2a17140d52a996ea6b8ddd949b3c08be1b.diff
-or-
See attached SVN patch.txt

-- 
Devin

_____________
The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch.txt
URL: <http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20131114/2a696ccb/attachment.txt>


More information about the freebsd-hackers mailing list