Fixing grep -D skip

John Baldwin jhb at freebsd.org
Fri Jan 18 17:13:13 UTC 2013


On Thursday, January 17, 2013 9:33:53 pm David Xu wrote:
> I am trying to fix a bug in GNU grep, the bug is if you
> want to skip FIFO file, it will not work, for example:
> 
> grep -D skip aaa .
> 
> it will be stucked on a FIFO file.
> 
> Here is the patch:
> http://people.freebsd.org/~davidxu/patch/grep.c.diff2
> 
> Is it fine to be committed ?

I think the first part definitely looks fine.  My guess is the non-blocking 
change is als probably fine, but that should be run by the bsdgrep person at 
least.

-- 
John Baldwin


More information about the freebsd-hackers mailing list