Import crt{begin,end}.S from NetBSD

[Garrett Cooper]

On Thu, Jun 14, 2012 at 7:39 PM, Richard Yao <ryao at gentoo.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 06/14/12 22:24, Alexander Kabaev wrote:
>> On Thu, 14 Jun 2012 22:00:18 -0400 Richard Yao <ryao at gentoo.org>
>> wrote:
>>
>>
>>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
>>
>>> On 06/14/12 20:51, Alexander Kabaev wrote:
>>>> On Thu, 14 Jun 2012 14:54:28 -0400 Richard Yao
>>>> <ryao at gentoo.org> wrote:
>>>>
>>>>> NetBSD has replacements for GCC's crt{begin,end}.S:
>>>>>
>>>>> http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/csu/arch/?only_with_tag=MAIN
>>>>>
>>>>>
>>>>>
> This would complement compiler-rt and libstdc++. We intend to
>>>>> import it in downstream Gentoo FreeBSD.
>>>>>
>>>>> Could this be imported into FreeBSD-CURRENT?
>>>>
>>>> Apart from licensing, what others reasons are there to do
>>>> that?
>>>>
>>> These components should not be tied to a specific compiler. If
>>> GCC is going to be deprecated, then they should be replaced.
>>
>>> Anyway, having this tied to GCC has caused headaches for Clang
>>> integration in Gentoo. In particular, we let the user pick the
>>> toolchain that he uses, so we cannot place GCC's crt{begin,end}.o
>>> in the same location that FreeBSD uses. This makes it difficult
>>> for Clang to find the correct crt{begin,end}.o. We will likely
>>> import the NetBSD crt{begin,end}.S code to rectify this, but it
>>> would be preferable to do this in upstreamFreeBSD.
>>
>> Assuming NetBSD version is a direct plugin for crtbegin/end
>> provided by GCC, I see no reason why we cannot do that. Are you are
>> willing to do the work and submit the patch, or would like to wait
>> for someone on our side?
>
> Gentoo FreeBSD is currently based on FreeBSD 9-RELEASE. I plan to do
> the work to import this downstream within the week, but I am not
> running CURRENT. It might be necessary to iterate on the patches
> before they can be merged. When I have them, should I file a PR or
> post them to the list?

    File a PR, post a link to the PR on a list / to devs generally is
the best way to go.
Thanks!
-Garrett