Forgotten debuging flags in 9.0 RELEASE

John Baldwin jhb at freebsd.org
Wed Apr 25 14:15:30 UTC 2012


On Wednesday, April 25, 2012 9:37:09 am rank1seeker at gmail.com wrote:
> ----- Original Message -----
> From: John Baldwin <jhb at freebsd.org>
> To: freebsd-hackers at freebsd.org
> Cc: rank1seeker at gmail.com, dougb at freebsd.org
> Date: Mon, 23 Apr 2012 14:28:49 -0400
> Subject: Re: Forgotten debuging flags in 9.0 RELEASE
> 
> > On Saturday, April 21, 2012 12:43:28 pm rank1seeker at gmail.com wrote:
> > > Whenever I run:
> > > # make distribution
> > > 
> > > I also get:
> > > + ln -s ../var/named/etc/namedb /usr/TZONE/etc/namedb
> > > + ln -s mail/aliases /usr/TZONE/etc/aliases
> > > 
> > > Looks like someone forgot to turn off/remove debuging flags(set -x), 
before 
> > building 9.0 RELEASE
> > 
> > Actually, those have been there for at least 7 years.  The namedb one was 
> > first added in r136242, and the mail one is older than that.
> > 
> > > /usr/src/etc/Makefile:
> > > ----
> > >         @if [ ! -e ${DESTDIR}/etc/namedb ]; then \
> > >                 set -x; \
> > >                 ln -s ../var/named/etc/namedb ${DESTDIR}/etc/namedb; \
> > >         fi
> > > ----
> > >         @if [ -d ${DESTDIR}/etc/mail -a -f ${DESTDIR}/etc/mail/aliases -
a \
> > >               ! -f ${DESTDIR}/etc/aliases ]; then \
> > >                 set -x; \
> > >                 ln -s mail/aliases ${DESTDIR}/etc/aliases; \
> > >         fi
> > > ----
> > 
> > -- 
> > John Baldwin
> > 
> 
> 
> 7 years ?!?
> Wow, it's time to get rid of them, unless someone finds it criticaly 
useful/needed.

Alternatively, it hasn't broken anything in 7 years. :)

> My build script had many set -x lines, so I was thinking it was my script 
outputing it.
> I thought I was going mad, by being unable to find where am I using 'ln -s' 
lines, even after I've removed all 'set -x' lines

I will defer to dougb@ on this one as it is a chunk of the code he maintains.
You will have to convince him that the verbosity is somehow harmful.

-- 
John Baldwin


More information about the freebsd-hackers mailing list