[PATCH] __FreeBSD_cc_version in <sys/cdefs.h>

Warner Losh imp at bsdimp.com
Sun Jul 10 05:19:41 UTC 2011


On Jul 5, 2011, at 7:36 AM, Robert Millan wrote:

> 2011/7/5 Dimitry Andric <dim at freebsd.org>:
>> As far as I can see, this code only gives warnings when compiled with
>> gcc 4.5 or higher, and when using the -Wundef flag.  Isn't it easier to
>> just remove the -Wundef flag here?
> 
> Here's a patch to remove -Wundef.  I think it's a bad idea however,
> IMHO it's better to fix the cause of the warning instead.

I think it is a better idea to fix the warning too.  I liked your first patch better.

Warner



More information about the freebsd-hackers mailing list