[patch] have rtprio check that arguments are numeric;
change atoi to strtol
Alexander Best
arundel at freebsd.org
Tue Jan 4 13:49:40 UTC 2011
On Tue Jan 4 11, John Baldwin wrote:
> On Tuesday, January 04, 2011 6:25:02 am Kostik Belousov wrote:
> > On Tue, Jan 04, 2011 at 11:40:45AM +0100, Giorgos Keramidas wrote:
> > @@ -123,12 +121,28 @@ main(argc, argv)
> > }
> > exit(0);
> > }
> > - exit (1);
> > + exit(1);
> > +}
> > +
> > +static int
> > +parseint(const char *str, const char *errname)
> > +{
> > + char *endp;
> > + long res;
> > +
> > + errno = 0;
> > + res = strtol(str, &endp, 10);
> > + if (errno != 0 || endp == str || *endp != '\0')
> > + err(1, "%s shall be a number", errname);
>
> Small nit, maybe use 'must' instead of 'shall'.
it seems at some point there has been a massive usage of the term 'shall' in
manual pages, which people tried to get rid of. hence the
'usr/share/examples/mdoc/deshallify.sh' script.
maybe this should be noted in style(9)?
cheers.
alex
>
> --
> John Baldwin
--
a13x
More information about the freebsd-hackers
mailing list