empty function macros

[Alexander Best]

On Tue Feb  1 11, Roman Divacky wrote:
> On Mon, Jan 31, 2011 at 09:51:58AM +0000, Alexander Best wrote:
> > On Mon Jan 31 11, Roman Divacky wrote:
> > > no problem with this with clang :)
> > 
> > hmmmmm....so compiling the following code
> > 
> > int
> > main(int argc, char **argv)
> > {
> > if (1<2)
> >     ;
> > }
> > 
> > with clang -Werror code.c -o code works for you?
> 
> if (1<2)
>  ;
> 
> gives a warning (and it should), on the other hand
> 
> #define NOTHING
> 
> if (1<2)
>  NOTHING;
> 
> does not warn, which is what you want right?

actually

#define NOTHING

int
main(int argc, char **argv)
{
if (1<2)
    NOTHING;

return (0);
}

*does* warn for me:

otaku% clang test.c -o test      
test.c:7:12: warning: if statement has empty body [-Wempty-body]
    NOTHING;
           ^
1 warning generated.

..gcc on the otherhand will only warn with -Wextra. so the questions still
stands:

should

#define NOTHING

be replaced with

#define NOTHING do { } while (0)

?

cheers.
alex

-- 
a13x