strange printf(9) format specifier ("Z") in dev/drm code

Alexander Best arundel at freebsd.org
Fri Dec 16 11:27:35 UTC 2011


On Tue Dec  6 11, David Schultz wrote:
> On Sun, Dec 04, 2011, Alexander Best wrote:
> > ... i couldn't find a reference to an upercase "Z" in the printf(9) man page.
> > i talked to dinoex on #freebsd-clang (EFNet) and he said that the "Z" might
> > come from linux'es libc5 and is the equaivalent to glibc's "z".
> > 
> > can we adjust those lines, so the clang warnings disappear?
> 
> Yes, 'Z' is an alias for 'z' that is deprecated in glibc and
> unsupported in FreeBSD, so changing the case should fix it.

any chance we could get the following patch committed?

cheers.
alex
-------------- next part --------------
Index: sys/dev/drm/mga_drv.h
===================================================================
--- sys/dev/drm/mga_drv.h	(revision 228567)
+++ sys/dev/drm/mga_drv.h	(working copy)
@@ -288,7 +288,7 @@
 do {									\
 	if ( MGA_VERBOSE ) {						\
 		DRM_INFO( "BEGIN_DMA( %d )\n", (n) );		\
-		DRM_INFO( "   space=0x%x req=0x%Zx\n",			\
+		DRM_INFO( "   space=0x%x req=0x%zx\n",			\
 			  dev_priv->prim.space, (n) * DMA_BLOCK_SIZE );	\
 	}								\
 	prim = dev_priv->prim.start;					\
@@ -338,7 +338,7 @@
 #define DMA_WRITE( offset, val )					\
 do {									\
 	if ( MGA_VERBOSE ) {						\
-		DRM_INFO( "   DMA_WRITE( 0x%08x ) at 0x%04Zx\n",	\
+		DRM_INFO( "   DMA_WRITE( 0x%08x ) at 0x%04zx\n",	\
 			  (u32)(val), write + (offset) * sizeof(u32) );	\
 	}								\
 	*(volatile u32 *)(prim + write + (offset) * sizeof(u32)) = val;	\


More information about the freebsd-hackers mailing list