[nvi-iconv]Call for test

[Zhihao Yuan]

On Thu, Aug 18, 2011 at 9:26 PM, Test Rat <ttsestt at gmail.com> wrote:
> timp <timp87 at gmail.com> writes:
>
>> Hi!
>> I just tried you patch on latest current with clang.
>>
>> [root at current64 /usr/src]# uname -a
>> FreeBSD current64 9.0-BETA1 FreeBSD 9.0-BETA1 #0: Thu Aug 18 03:56:45 MSK
>> 2011     mox at current64:/usr/obj/usr/src/sys/GENERIC  amd64
>>
>> [root at current64 /usr/src]# patch < ~/nvi2-freebsd-2011-08-17.diff
> [...]
>> ===> usr.bin/vi (depend)
>> make: don't know how to make cl_bsd.c. Stop
>> *** Error code 2
>
> Use `-p0' otherwise new directories won't be created. This is documented
> in patch(1). And cl_bsd.c ended up in current directory (/usr/src)
>
>  $ diffstat ~/nvi2-freebsd-2011-08-17.diff.gz | fgrep cl_bsd.c
>   contrib/nvi2/cl/cl_bsd.c                |  346 +++

zzz... I always use -p0 but I did not know what it does...

>
> Zhihao Yuan <lichray at gmail.com> writes:
>> The patch will create contrib/nvi2, and it will not remove the unused
>> contrib/nvi (patch(1) can not really remove files anyway).
>
> patch(1) can remove *empty* files with `-E', e.g.
>
>  $ svn rm UPDATING
>  $ svn di UPDATING | patch -E -d /usr/src

Got it. But removing contrib/nvi with patch will just double the patch
size anyway. A svn rm will do it if some day the patch got committed.

> _______________________________________________
> freebsd-hackers at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
> To unsubscribe, send any mail to "freebsd-hackers-unsubscribe at freebsd.org"
>



-- 
Zhihao Yuan, nickname lichray
The best way to predict the future is to invent it.
___________________________________________________
4BSD -- http://4bsd.biz/