little mistake in rc.subr?

[Paul Schenkeveld]

On Mon, Sep 27, 2010 at 02:01:29PM +0200, Lars Engels wrote:
> On Mon, Sep 27, 2010 at 03:04:21PM +0400, Dmitry Banshchikov wrote:
> > Hello,
> > 
> > In /etc/rc.subr, at line 231, there is:
> > 
> > if [ ! -f $_pidfile ]; then
> > debug "pid file ($_pidfile): not readable."
> >     return
> > fi
> > 
> > Is check "[ ! -r $_pidfile ]" more correct?
> 
> There's pratically no difference. rc stuff is run as root, so if there's
> a file, it's readable, if there's no file, then the debug message is
> printed.

And -f also checks that it is a regular file (or symlink to a regular
file).